From a607029f07c88c148dc81a450e85e5d5ff3b853e Mon Sep 17 00:00:00 2001 From: "Dustin L. Howett" Date: Tue, 19 Nov 2024 16:52:35 -0600 Subject: [PATCH] Don't allow orphaned profiles to show up in the Default list (#18207) --- src/cascadia/TerminalSettingsEditor/LaunchViewModel.cpp | 2 +- src/cascadia/TerminalSettingsEditor/ProfileViewModel.idl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cascadia/TerminalSettingsEditor/LaunchViewModel.cpp b/src/cascadia/TerminalSettingsEditor/LaunchViewModel.cpp index 29364e0e61f..856f78a0dce 100644 --- a/src/cascadia/TerminalSettingsEditor/LaunchViewModel.cpp +++ b/src/cascadia/TerminalSettingsEditor/LaunchViewModel.cpp @@ -332,7 +332,7 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation // from menus, but still work as the startup profile for instance. for (const auto& profile : allProfiles) { - if (!profile.Deleted()) + if (!profile.Deleted() && !profile.Orphaned()) { profiles.emplace_back(profile); } diff --git a/src/cascadia/TerminalSettingsEditor/ProfileViewModel.idl b/src/cascadia/TerminalSettingsEditor/ProfileViewModel.idl index dd4cbd6d5a5..f3d1bd44633 100644 --- a/src/cascadia/TerminalSettingsEditor/ProfileViewModel.idl +++ b/src/cascadia/TerminalSettingsEditor/ProfileViewModel.idl @@ -84,7 +84,7 @@ namespace Microsoft.Terminal.Settings.Editor void CreateUnfocusedAppearance(); void DeleteUnfocusedAppearance(); - Boolean Orphaned { get; }; + Boolean Orphaned { get; }; OBSERVABLE_PROJECTED_PROFILE_SETTING(String, Name); PERMANENT_OBSERVABLE_PROJECTED_SETTING(Guid, Guid); OBSERVABLE_PROJECTED_PROFILE_SETTING(String, Source);