From b506d0906caf7d1a3b05753f82d254da99d94f1e Mon Sep 17 00:00:00 2001
From: Mine Starks <16928427+minestarks@users.noreply.github.com>
Date: Fri, 2 Feb 2024 09:58:43 -0800
Subject: [PATCH] Fix error reporting in vscode integration tests (#1105)

I accidentally broke VS Code integration test error reporting with
#1015. `run()` should raise an error if any tests fail, but it was
swallowing the error after writing to console.

This made it so that CI would succeed even when tests failed. I did
manually look through the last few days' runs and didn't see any actual
failures.
---
 vscode/test/suites/run.ts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/vscode/test/suites/run.ts b/vscode/test/suites/run.ts
index ea4f8db9ae..d15b3993ab 100644
--- a/vscode/test/suites/run.ts
+++ b/vscode/test/suites/run.ts
@@ -30,8 +30,10 @@ export function runMochaTests(requireTestModules: () => void): Promise<void> {
           console.error(
             `[error] ${failures} vscode integration test(s) failed.`,
           );
+          e(new Error(`${failures} vscode integration test(s) failed.`));
+        } else {
+          c();
         }
-        c();
       });
     } catch (err) {
       console.error(err);