Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing X on pylance has crashed notification should be treated as a No #6156

Closed
lramos15 opened this issue Jul 17, 2024 · 2 comments
Closed
Assignees
Labels
bug Something isn't working fixed in next version (release) A fix has been implemented and will appear in an upcoming version

Comments

@lramos15
Copy link
Member

  1. Crash your pylance 🎉
  2. See the notification that asks you if you want to spawn it as a node process instead
  3. Click X
  4. 🐛 Notification reappears.

This is a bit of UX smell in my opinion as I clicked X to get it out of the way so I could focus on my work and it kept popping back up. This is a different behavior than most notifications in VS Code.

@github-actions github-actions bot added the needs repro Issue has not been reproduced yet label Jul 17, 2024
@rchiodo
Copy link
Contributor

rchiodo commented Jul 17, 2024

Thanks for the issue.

That's a bug in this logic here:
https://github.com/microsoft/pyrx/blob/6cbd08616443676ee9b0496952ab445e287ce4c6/packages/vscode-pylance/src/extension.ts#L132

The loop there was intended to keep the dialog up if the user clicked the help button, but not if they clicked the X.

@StellaHuang95 StellaHuang95 added bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version and removed needs repro Issue has not been reproduced yet labels Jul 19, 2024
@heejaechang heejaechang removed the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label Jul 22, 2024
@StellaHuang95 StellaHuang95 added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label Jul 23, 2024
@heejaechang heejaechang added fixed in next version (release) A fix has been implemented and will appear in an upcoming version and removed fixed in next version (main) A fix has been implemented and will appear in an upcoming version labels Jul 23, 2024
@heejaechang
Copy link
Contributor

This issue has been fixed in prerelease version 2024.7.102, which we've just released. You can find the changelog here: CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next version (release) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

4 participants