From ee14133c76543f5c25815cdf10e2a8b246e447a1 Mon Sep 17 00:00:00 2001 From: Taylor Beebe <31827475+TaylorBeebe@users.noreply.github.com> Date: Sat, 2 Mar 2024 09:44:00 -0800 Subject: [PATCH] Add StackCheckLib Instances to Platform DSC Files (#202) ## Description An instance of StackCheckLib must be in each DSC to accommodate -fstack-protector and /GS flags. - [x] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested Tested in pipelines ## Integration Instructions N/A --- DfciPkg/DfciPkg.dsc | 1 + ZeroTouchPkg/ZeroTouchPkg.dsc | 1 + 2 files changed, 2 insertions(+) diff --git a/DfciPkg/DfciPkg.dsc b/DfciPkg/DfciPkg.dsc index aac6d1ea..fc7a9c71 100644 --- a/DfciPkg/DfciPkg.dsc +++ b/DfciPkg/DfciPkg.dsc @@ -80,6 +80,7 @@ UnitTestLib|UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf ResetSystemLib|MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.inf + NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf [LibraryClasses.common.UEFI_APPLICATION] UnitTestPersistenceLib|UnitTestFrameworkPkg/Library/UnitTestPersistenceLibSimpleFileSystem/UnitTestPersistenceLibSimpleFileSystem.inf diff --git a/ZeroTouchPkg/ZeroTouchPkg.dsc b/ZeroTouchPkg/ZeroTouchPkg.dsc index 9930447a..ef41f553 100644 --- a/ZeroTouchPkg/ZeroTouchPkg.dsc +++ b/ZeroTouchPkg/ZeroTouchPkg.dsc @@ -21,6 +21,7 @@ [PcdsFixedAtBuild] [LibraryClasses.common] + NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf [LibraryClasses.IA32]