Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't rename symbol while someone else is editing the same document #4754

Open
ihatecsv opened this issue Aug 26, 2022 · 1 comment
Open

Comments

@ihatecsv
Copy link

Describe what happened:
Trying to rename a symbol in a file that's being edited by someone else causes the rename symbol box to disappear immediately upon their edit, making it very hard to rename a symbol unless all editors have stopped typing.

What was your system configuration?
Product and Version [VS/VSCode]: VSCode 1.70.2
OS Version[macOS/Windows]: macOS 12.5
Live Share Extension Version: v1.0.5695
Target Platform or Language [e.g. Node.js]: TypeScript (TSX) for React

Steps to Reproduce / Scenario:

  1. Start a new live share
  2. Create a named variable
  3. Have user 1 right click on variable and click "Rename Symbol"
  4. Have user 2 edit the document containing the symbol being renamed
@ErikvO
Copy link

ErikvO commented Mar 20, 2023

The same thing happens to me for any Quick Action / Refactoring. I press Ctrl-. to open the menu, but as soon as anyone starts typing, it closes again, sometimes before it is fully loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants