Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl + Z cancels other people's changes #1659

Closed
dsseng opened this issue Feb 8, 2019 · 5 comments
Closed

Ctrl + Z cancels other people's changes #1659

dsseng opened this issue Feb 8, 2019 · 5 comments

Comments

@dsseng
Copy link

dsseng commented Feb 8, 2019

Product and Version [VS/VSCode]: 1.31.0
OS Version [macOS/Windows]: Ubuntu 18.04
Live Share Extension Version: v0.3.890
Target Platform or Language [e.g. Node.js]: TypeScript

Steps to Reproduce / Scenario:

  1. Edit code with some other people
  2. Ctrl + Z
  3. The last edit ever has been cancelled, not last your edit.
@lukepighetti
Copy link

lukepighetti commented Feb 8, 2019

I'll just chime in and say that this is expected behavior for me personally. It lets me reverse a file that someone has been working on.

@dsseng
Copy link
Author

dsseng commented Feb 9, 2019

@lukepighetti for me it's more expected if Ctrl + Z returns code I write, not that other coder write

@lukepighetti
Copy link

lukepighetti commented Feb 9, 2019

I'm pretty sure diffing in a way that would let you do a partial undo is non-trivial. Also, when I'm pair programming with someone I need to be able to undo stuff they write if I want to show them an alternative method. Otherwise I will be asking them to hit undo for me. Not good.

@hickeng
Copy link

hickeng commented Feb 19, 2019

Dup of #1439 and there's discussion there about trade-offs and expected usage patterns.

@daytonellwanger
Copy link
Collaborator

Closing this issue to keep discussion of this issue confined to 1439.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants