Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0010] Include a pseudo-hlsl/c++ class declaration for vk::BufferPointer<T,A> and any associated built-in functions/types #45

Closed
llvm-beanz opened this issue Apr 14, 2023 · 3 comments · Fixed by #56
Labels
active proposal Issues relating to active proposals

Comments

@llvm-beanz
Copy link
Collaborator

Which proposal does this relate to?
0010-vk-buffer-ref.md

Describe the issue or outstanding question.
For clarity and understanding of the spec it would be helpful to include a pseudo HLSL/C++ class declaration for vk::BufferPointer<T,A> in the spec and any reasonable pseudo-code for implementation. This both will help in the readability and understanding of the new objects and APIs and helps us move toward our goal of being able to define HLSL types in HLSL.

Additional context
See initial review discussion.

@llvm-beanz llvm-beanz added the active proposal Issues relating to active proposals label Apr 14, 2023
@devshgraphicsprogramming

would be also useful to have a #ifdef __cplusplus version so we can share structure definitions between C++ and HLSL

@llvm-beanz
Copy link
Collaborator Author

Providing a C++ implementation of HLSL built-in types is not a goal of our spec process. I filed this to request a pseudo-object definition to help with the readability of the spec, that's not the same as making code that can actually be compiled.

@devshgraphicsprogramming

but it would be a very small step to provide one in this case.

greg-lunarg added a commit to greg-lunarg/hlsl-specs that referenced this issue May 9, 2023
llvm-beanz pushed a commit that referenced this issue Sep 1, 2023
* Add pseudo-class definition to vk::BufferPointer spec

Fixes #45

* Change default alignment to alignof(S)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
active proposal Issues relating to active proposals
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants