Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert poetry #2561

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Revert poetry #2561

merged 1 commit into from
Jan 7, 2025

Conversation

sarsharma
Copy link
Member

@sarsharma sarsharma commented Jan 7, 2025

pinning poetry version to 1.8.5

This should fix #2557

@sarsharma sarsharma requested a review from a team as a code owner January 7, 2025 12:34
@sarsharma sarsharma closed this Jan 7, 2025
@sarsharma sarsharma force-pushed the user/sartsharma/revert-poetry branch from c71f1ae to d37b222 Compare January 7, 2025 12:38
Signed-off-by: Sarthak Sharma <[email protected]>
@sarsharma sarsharma reopened this Jan 7, 2025
Copy link
Collaborator

@kumaraksh1 kumaraksh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@surenderssm
Copy link
Member

Let's link the reported issue in this PR.

@sarsharma sarsharma merged commit ef3fb2f into main Jan 7, 2025
1 check passed
@sarsharma sarsharma deleted the user/sartsharma/revert-poetry branch January 7, 2025 13:17
@MaartenUreel
Copy link

And why not just switch the flag --no-dev which has been deprecated for a long time to --only main?

It is a minimal change that would allow to use a recent up-to-date Poetry version instead if pinning an old version...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment of Python app fails because of usage of --no-dev parameter
4 participants