Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXIL validation should run ComputeViewIdState pass #4256

Open
jenatali opened this issue Feb 13, 2022 · 0 comments
Open

DXIL validation should run ComputeViewIdState pass #4256

jenatali opened this issue Feb 13, 2022 · 0 comments
Milestone

Comments

@jenatali
Copy link
Member

The serialized view ID state in the DXIL module is not validated against the rest of the contents of the module. Tools that produce DXIL (like the Mesa DXIL writer) can just not emit a view ID metadata node, even though they're using view ID, and validation will succeed. This also includes the input -> output dependency mapping data, which can just be omitted entirely without affecting validation.

If drivers need this data, it should be validated as part of the validator.

@llvm-beanz llvm-beanz added the needs-triage Awaiting triage label Jun 29, 2023
@damyanp damyanp moved this to Triaged in HLSL Triage Apr 22, 2024
@damyanp damyanp added this to the Backlog milestone Apr 22, 2024
@damyanp damyanp removed the needs-triage Awaiting triage label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triaged
Development

No branches or pull requests

3 participants