Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to abort compilation when generating errors #3496

Closed
vcsharma opened this issue Feb 23, 2021 · 1 comment
Closed

Add an option to abort compilation when generating errors #3496

vcsharma opened this issue Feb 23, 2021 · 1 comment
Labels
enhancement Feature suggestion

Comments

@vcsharma
Copy link
Contributor

vcsharma commented Feb 23, 2021

It came up during review of #3043 that when generating compilation errors, it is desirable in most cases to stop further compilation and exit. It seems the current mechanism doesn't support that.

Here is a relevant comment from @tex3d

Currently, it seems the only way to abort the pipeline is with a report_fatal_error, which currently raises a structured exception - which is way too harsh for something like this, and we should likely change report_fatal_error to throw a C++ exception, since we still have a chance of emitting a useful error message then.

@bob80905
Copy link
Collaborator

This issue was completed with:
#4427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature suggestion
Projects
None yet
Development

No branches or pull requests

2 participants