Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remainder of inout signature element not passed through when one component is modified #2528

Open
tex3d opened this issue Oct 17, 2019 · 1 comment
Labels
bug Bug, regression, crash fxc-disagrees Issues tracking differences between FXC and DXC
Milestone

Comments

@tex3d
Copy link
Contributor

tex3d commented Oct 17, 2019

In the case of an inout signature element, we do not pass through components not modified by the shader unless no components are touched.

The following test case succeeds if you do not write to pos.w, but fails with a validation error if you do since we do not output pos.xyz. Fxc does pass these through, so we should fix this.

// RUN: %dxc -E main -T vs_6_0 %s | FileCheck %s

// CHECK: call void @dx.op.storeOutput.f32(i32 5, i32 0, i32 0, i8 0,
// CHECK: call void @dx.op.storeOutput.f32(i32 5, i32 0, i32 0, i8 1,
// CHECK: call void @dx.op.storeOutput.f32(i32 5, i32 0, i32 0, i8 2,
// CHECK: call void @dx.op.storeOutput.f32(i32 5, i32 0, i32 0, i8 3,

// Should pass the rest (xyz) of SV_Position through
void main(inout float4 pos: SV_Position) {
  pos.w = 1;
}
@tex3d tex3d added the bug Bug, regression, crash label Oct 26, 2019
@pow2clk pow2clk added the fxc-disagrees Issues tracking differences between FXC and DXC label Jun 18, 2024
@damyanp damyanp added this to the Dormant milestone Jun 18, 2024
@damyanp
Copy link
Member

damyanp commented Jun 18, 2024

It's not entirely clear that this is something that is likely to impact real-life scenarios. Until we have data otherwise, setting this to dormant.

@damyanp damyanp moved this to Triaged in HLSL Triage Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug, regression, crash fxc-disagrees Issues tracking differences between FXC and DXC
Projects
Status: Triaged
Development

No branches or pull requests

3 participants