Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide .winmd (win32metadata) files for the Agility SDK #79

Closed
MarijnS95 opened this issue Nov 16, 2022 · 5 comments
Closed

Provide .winmd (win32metadata) files for the Agility SDK #79

MarijnS95 opened this issue Nov 16, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@MarijnS95
Copy link
Contributor

In order to bind the most recent D3D12 Agility SDK in languages other than C, such as Rust, .winmd metadata files need to be generated for windows-rs to generate proper bindings. According to @mikebattista all the tooling exists and the repo just needs to build/provide them (I think based on .idl or .h files in this repo, by generating and publishing them as part of a GitHub release or inside the NuGet header package?): microsoft/win32metadata#580 (comment)

@jenatali
Copy link
Member

This sounds like goodness. I'm on-board as long as the maintenance cost isn't too high, and we can get instructions for how to set it up.

@mikebattista, sounds like you might be the person we need to work with to set this up? We can follow up internally if you prefer.

@MarijnS95
Copy link
Contributor Author

@jenatali if at all possible I think it'd be great to integrate this with GitHub actions, so that you can essentially let the CI generate these without setting up any local environment, and it'd be accessible for anyone with push rights (also in forks) for convenience. These can also upload artifacts right to a release afaik.

Fwiw supposedly @riverar is the one tasked with writing documentation for this, and the one who's the most likely to help us out.

@riverar
Copy link

riverar commented Nov 16, 2022

I can help get things moving, standby for PR. It will require others to verify the output and tweak (see churn on win32metadata to get an idea of what you're signing up for).

@damyanp
Copy link
Member

damyanp commented Jan 25, 2023

This is resolved by microsoft/win32metadata#1445 - win32metadata is now able to be easily kept up to date with the latest Agility SDK releases.

@MarijnS95
Copy link
Contributor Author

Thanks, closing. Curious to see how quickly https://github.com/microsoft/DirectX-Headers/releases/tag/v1.610.0, which landed an hour ago, makes it into win32metadata and windows-rs. Is anyone having a notification trigger and/or responsibility for putting these releases through to win32metadata proactively?

@MarijnS95 MarijnS95 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants