Skip to content

Commit

Permalink
Don't mark eslintrc deletion as "Check Config" (#1137)
Browse files Browse the repository at this point in the history
  • Loading branch information
@jakebailey
jakebailey authored Jan 30, 2025
1 parent 1dd62db commit a391346
Show file tree
Hide file tree
Showing 14 changed files with 788 additions and 0 deletions.
3 changes: 3 additions & 0 deletions packages/mergebot/src/_tests/fixtures/71725/_downloads.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"enhance__enhance": 0
}
6 changes: 6 additions & 0 deletions packages/mergebot/src/_tests/fixtures/71725/_files.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"10894aa4e8d1717516ae8867f3fbaa50e88785ea:types/enhance__enhance/.eslintrc.json": "{\n \"rules\": {\n \"@definitelytyped/no-type-only-packages\": \"off\"\n }\n}\n",
"10894aa4e8d1717516ae8867f3fbaa50e88785ea:types/enhance__enhance/.npmignore": "*\n!**/*.d.ts\n!**/*.d.cts\n!**/*.d.mts\n!**/*.d.*.ts\n",
"10894aa4e8d1717516ae8867f3fbaa50e88785ea:types/enhance__enhance/package.json": "{\n \"name\": \"@types/enhance__enhance\",\n \"private\": true,\n \"version\": \"2.0.9999\",\n \"type\": \"module\",\n \"projects\": [\n \"https://github.com/enhance-dev\"\n ],\n \"dependencies\": {},\n \"devDependencies\": {\n \"@types/enhance__enhance\": \"workspace:.\"\n },\n \"owners\": [\n {\n \"name\": \"Alex Gawley\",\n \"githubUsername\": \"agawley\"\n }\n ]\n}\n",
"10894aa4e8d1717516ae8867f3fbaa50e88785ea:types/enhance__enhance/tsconfig.json": "{\n \"compilerOptions\": {\n \"module\": \"node16\",\n \"lib\": [\n \"es6\"\n ],\n \"noImplicitAny\": true,\n \"noImplicitThis\": true,\n \"strictNullChecks\": true,\n \"strictFunctionTypes\": true,\n \"types\": [],\n \"noEmit\": true,\n \"forceConsistentCasingInFileNames\": true\n },\n \"files\": [\"index.d.ts\", \"enhance__enhance-tests.ts\"]\n}\n"
}
322 changes: 322 additions & 0 deletions packages/mergebot/src/_tests/fixtures/71725/_response.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,322 @@
{
"data": {
"repository": {
"id": "MDEwOlJlcG9zaXRvcnk2MDkzMzE2",
"pullRequest": {
"id": "PR_kwDOAFz6BM6IqM54",
"title": "Add type definitions for Enhance https://enhance.dev/",
"createdAt": "2025-01-22T17:33:05Z",
"author": {
"login": "agawley",
"__typename": "User"
},
"authorAssociation": "FIRST_TIME_CONTRIBUTOR",
"baseRef": {
"name": "master",
"__typename": "Ref"
},
"labels": {
"nodes": [
{
"name": "New Definition",
"__typename": "Label"
},
{
"name": "Self Merge",
"__typename": "Label"
},
{
"name": "Maintainer Approved",
"__typename": "Label"
},
{
"name": "Check Config",
"__typename": "Label"
}
],
"__typename": "LabelConnection"
},
"isDraft": false,
"mergeable": "MERGEABLE",
"number": 71725,
"state": "OPEN",
"headRefOid": "10894aa4e8d1717516ae8867f3fbaa50e88785ea",
"changedFiles": 6,
"additions": 309,
"deletions": 0,
"commitIds": {
"nodes": [
{
"commit": {
"oid": "c8c77336a32b7e1e819d5fb1f4511ccb2bfc8161",
"parents": {
"nodes": [
{
"oid": "1d976b9454356ea4146621002c270b78b2c4d7cf",
"__typename": "Commit"
}
],
"__typename": "CommitConnection"
},
"__typename": "Commit"
},
"__typename": "PullRequestCommit"
},
{
"commit": {
"oid": "3421295b9d19ba8fb16eaaaa7544511071850dd2",
"parents": {
"nodes": [
{
"oid": "c8c77336a32b7e1e819d5fb1f4511ccb2bfc8161",
"__typename": "Commit"
}
],
"__typename": "CommitConnection"
},
"__typename": "Commit"
},
"__typename": "PullRequestCommit"
},
{
"commit": {
"oid": "10894aa4e8d1717516ae8867f3fbaa50e88785ea",
"parents": {
"nodes": [
{
"oid": "3421295b9d19ba8fb16eaaaa7544511071850dd2",
"__typename": "Commit"
}
],
"__typename": "CommitConnection"
},
"__typename": "Commit"
},
"__typename": "PullRequestCommit"
}
],
"__typename": "PullRequestCommitConnection"
},
"timelineItems": {
"nodes": [],
"__typename": "PullRequestTimelineItemsConnection"
},
"reviews": {
"nodes": [
{
"author": {
"login": "rbuckton",
"__typename": "User"
},
"commit": {
"oid": "10894aa4e8d1717516ae8867f3fbaa50e88785ea",
"__typename": "Commit"
},
"comments": {
"nodes": [],
"__typename": "PullRequestReviewCommentConnection"
},
"authorAssociation": "MEMBER",
"state": "APPROVED",
"submittedAt": "2025-01-27T15:35:48Z",
"url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/71725#pullrequestreview-2575780333",
"__typename": "PullRequestReview"
}
],
"__typename": "PullRequestReviewConnection"
},
"commits": {
"totalCount": 3,
"nodes": [
{
"commit": {
"checkSuites": {
"nodes": [
{
"databaseId": 33388233461,
"app": {
"name": "GitHub Actions",
"__typename": "App"
},
"conclusion": "SUCCESS",
"resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/10894aa4e8d1717516ae8867f3fbaa50e88785ea/checks?check_suite_id=33388233461",
"status": "COMPLETED",
"url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/10894aa4e8d1717516ae8867f3fbaa50e88785ea/checks?check_suite_id=33388233461",
"checkRuns": {
"nodes": [
{
"title": null,
"__typename": "CheckRun"
}
],
"__typename": "CheckRunConnection"
},
"createdAt": "2025-01-22T18:01:25Z",
"workflowRun": {
"file": {
"path": ".github/workflows/CI.yml",
"__typename": "WorkflowRunFile"
},
"__typename": "WorkflowRun"
},
"__typename": "CheckSuite"
}
],
"__typename": "CheckSuiteConnection"
},
"status": null,
"authoredDate": "2025-01-22T18:01:15Z",
"committedDate": "2025-01-22T18:01:15Z",
"pushedDate": null,
"oid": "10894aa4e8d1717516ae8867f3fbaa50e88785ea",
"__typename": "Commit"
},
"__typename": "PullRequestCommit"
}
],
"__typename": "PullRequestCommitConnection"
},
"comments": {
"totalCount": 4,
"nodes": [
{
"id": "IC_kwDOAFz6BM6bcLgn",
"author": {
"login": "typescript-bot",
"__typename": "User"
},
"databaseId": 2607855655,
"body": "@agawley Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `enhance__enhance` (*new!*) — [on npm](https://www.npmjs.com/package/@enhance/enhance), [on unpkg](https://unpkg.com/browse/@enhance/enhance@latest/)\n - 1 added owner: ✎@agawley\n - Config files to check:\n - [`enhance__enhance/.eslintrc.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/71725/files/10894aa4e8d1717516ae8867f3fbaa50e88785ea#diff-8396f43ae17f6ac375fa3ccd977f1fa5f4623a11ad7d4bb5d770a7f49d0feebd): edited\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=71725&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Only a DT maintainer can approve changes when there are new packages added\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->",
"createdAt": "2025-01-22T17:33:45Z",
"reactions": {
"nodes": [],
"__typename": "ReactionConnection"
},
"__typename": "IssueComment"
},
{
"id": "IC_kwDOAFz6BM6bcLiX",
"author": {
"login": "typescript-bot",
"__typename": "User"
},
"databaseId": 2607855767,
"body": "🔔 @agawley — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/71725/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n<!--typescript_bot_pinging-reviewers-others-->",
"createdAt": "2025-01-22T17:33:48Z",
"reactions": {
"nodes": [],
"__typename": "ReactionConnection"
},
"__typename": "IssueComment"
},
{
"id": "IC_kwDOAFz6BM6bcM6M",
"author": {
"login": "typescript-bot",
"__typename": "User"
},
"databaseId": 2607861388,
"body": "@agawley The CI build failed! Please [review the logs for more information](https://github.com/DefinitelyTyped/DefinitelyTyped/commit/c8c77336a32b7e1e819d5fb1f4511ccb2bfc8161/checks?check_suite_id=33386998199).\n\nOnce you've pushed the fixes, the build will automatically re-run. Thanks!\n\n**Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.**\n<!--typescript_bot_gh-actions-complaint-c8c7733-->",
"createdAt": "2025-01-22T17:36:11Z",
"reactions": {
"nodes": [],
"__typename": "ReactionConnection"
},
"__typename": "IssueComment"
},
{
"id": "IC_kwDOAFz6BM6b7mRi",
"author": {
"login": "typescript-bot",
"__typename": "User"
},
"databaseId": 2616091746,
"body": "@agawley: Everything looks good here. I am ready to merge this PR (at 10894aa) on your behalf whenever you think it's ready.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n\n<!--typescript_bot_merge-offer-->",
"createdAt": "2025-01-27T15:36:27Z",
"reactions": {
"nodes": [],
"__typename": "ReactionConnection"
},
"__typename": "IssueComment"
}
],
"__typename": "IssueCommentConnection"
},
"files": {
"totalCount": 6,
"nodes": [
{
"path": "types/enhance__enhance/.eslintrc.json",
"additions": 5,
"deletions": 0,
"__typename": "PullRequestChangedFile"
},
{
"path": "types/enhance__enhance/.npmignore",
"additions": 5,
"deletions": 0,
"__typename": "PullRequestChangedFile"
},
{
"path": "types/enhance__enhance/enhance__enhance-tests.ts",
"additions": 143,
"deletions": 0,
"__typename": "PullRequestChangedFile"
},
{
"path": "types/enhance__enhance/index.d.ts",
"additions": 121,
"deletions": 0,
"__typename": "PullRequestChangedFile"
},
{
"path": "types/enhance__enhance/package.json",
"additions": 19,
"deletions": 0,
"__typename": "PullRequestChangedFile"
},
{
"path": "types/enhance__enhance/tsconfig.json",
"additions": 16,
"deletions": 0,
"__typename": "PullRequestChangedFile"
}
],
"pageInfo": {
"hasNextPage": false,
"endCursor": "Ng",
"__typename": "PageInfo"
},
"__typename": "PullRequestChangedFileConnection"
},
"projectItems": {
"nodes": [
{
"id": "PVTI_lADOADeBNM4AkH1qzgWmdtQ",
"project": {
"id": "PVT_kwDOADeBNM4AkH1q",
"number": 1,
"__typename": "ProjectV2"
},
"fieldValueByName": {
"name": "Waiting for Author to Merge",
"field": {
"id": "PVTSSF_lADOADeBNM4AkH1qzgcYOEM",
"__typename": "ProjectV2SingleSelectField"
},
"__typename": "ProjectV2ItemFieldSingleSelectValue"
},
"updatedAt": "2025-01-27T18:45:02Z",
"__typename": "ProjectV2Item"
}
],
"__typename": "ProjectV2ItemConnection"
},
"__typename": "PullRequest"
},
"__typename": "Repository"
}
},
"loading": false,
"networkStatus": 7
}
65 changes: 65 additions & 0 deletions packages/mergebot/src/_tests/fixtures/71725/derived.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
{
"type": "info",
"now": "2025-01-30T19:56:06.175Z",
"pr_number": 71725,
"author": "agawley",
"headCommitOid": "10894aa4e8d1717516ae8867f3fbaa50e88785ea",
"mergeBaseOid": "1d976b9454356ea4146621002c270b78b2c4d7cf",
"lastPushDate": "2025-01-22T17:33:05.000Z",
"lastActivityDate": "2025-01-27T15:35:48.000Z",
"mergeOfferDate": "2025-01-27T15:36:27.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "enhance__enhance",
"kind": "add",
"files": [
{
"path": "types/enhance__enhance/.eslintrc.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-eslintrcjson) (check: `rules`)"
},
{
"path": "types/enhance__enhance/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/enhance__enhance/enhance__enhance-tests.ts",
"kind": "test"
},
{
"path": "types/enhance__enhance/index.d.ts",
"kind": "definition"
},
{
"path": "types/enhance__enhance/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/enhance__enhance/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"agawley"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "rbuckton",
"date": "2025-01-27T15:35:48.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2607855655,
"ciResult": "pass"
}
Loading

0 comments on commit a391346

Please sign in to comment.