Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why dependency on torchvision<0.17.0,>=0.16.0 ? #40

Open
carandraug opened this issue Aug 20, 2024 · 0 comments
Open

why dependency on torchvision<0.17.0,>=0.16.0 ? #40

carandraug opened this issue Aug 20, 2024 · 0 comments

Comments

@carandraug
Copy link

The current version of msclap (1.3.3) requires torchvision <0.17.0,>=0.16.0. This comes from describing it with:

torchvision = "^0.16.0"

The caret (^) there means any version that does not change the leftmost non-zero section, which effectively mean any 0.16 version only. This is quite strict, more than what is typically reasonable. Is it really necessary? I'm asking because ^ is often used incorrectly to mean any version but that has the same major version in which case the following should be used instead:

torchvision = "~0"

We have been using CLAP just fine with torchvision 0.17 for a while now. The problem with using torchvision 0.16 is that it requires older versions of pytorch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant