Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a modal dialog triggered if the experiment is truncated. #882

Open
iandobbie opened this issue Oct 3, 2023 · 3 comments
Open

Add a modal dialog triggered if the experiment is truncated. #882

iandobbie opened this issue Oct 3, 2023 · 3 comments

Comments

@iandobbie
Copy link
Collaborator

The log window contains an error if the experiment is truncated as not enough data has arrived, either something went wrong, maybe one or more images were dropped, or the users cancelled the collection. They have a couple of occasions that this happened at Diamond and the user was expecting the data to reconstruct.

I suggest that we put up a modal dialog to say at least something went wrong and the data file is not complete.

@carandraug
Copy link
Collaborator

Basically, we're forcing the user to acknowledge the error to avoid the error going unnoticed. Should we expand this to all errors (because if something escalates to the point of error, then it requires user attention)?

@iandobbie
Copy link
Collaborator Author

Yes. Not sure if we should force this for every error. Worth considering but also might be very annoying for the user.

This particular scenario should be rare and is important ensure the user knows that the collected data is likely useless.

@iandobbie
Copy link
Collaborator Author

I added a modal dialog that say file truncated ok to contnue to cancel to delete file, but then does not yet delete the file. Code is in https://github.com/iandobbie/cockpit/tree/truncated-file-modal-diaglog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants