Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache metrics for http clients #1700

Open
kubamarchwicki opened this issue Nov 11, 2019 · 2 comments
Open

Cache metrics for http clients #1700

kubamarchwicki opened this issue Nov 11, 2019 · 2 comments
Labels
enhancement A general enhancement help wanted An issue that a contributor can help us with waiting for feedback We need additional information before we can continue
Milestone

Comments

@kubamarchwicki
Copy link
Contributor

Both httpclient from Apache and OkHttp (which are instrumented by micrometer: OkHttpMetricsEventListener and #533) support provider driven caching (based on http headers)

It would be helpful (for the sake of completeness) for micrometer to provide insight to the state of caches (size, maxSize, hit and misses).

I've drafted a cache metrics for OkHttp which I'd like to get feedback ok: master...kubamarchwicki:httpclient-cache-metrics.
If that's something interesting, I'd hapilly finalize both OkHttp as well as httpclient.

@shakuzen shakuzen added the enhancement A general enhancement label Dec 3, 2019
@shakuzen shakuzen added this to the 1.x milestone Dec 3, 2019
@shakuzen
Copy link
Member

shakuzen commented Dec 3, 2019

@kubamarchwicki thank you for opening this issue. It sounds like a good addition to metrics provided. I took a quick look at the draft implementation. It looks like it is on the right track. Please open a pull request and we can proceed with getting this integrated.

@marcingrzejszczak
Copy link
Contributor

hey @kubamarchwicki, long time no see :) What about the PR, are you willing to file it?

@marcingrzejszczak marcingrzejszczak added the waiting for feedback We need additional information before we can continue label Dec 22, 2023
@shakuzen shakuzen added the help wanted An issue that a contributor can help us with label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement help wanted An issue that a contributor can help us with waiting for feedback We need additional information before we can continue
Projects
None yet
Development

No branches or pull requests

3 participants