Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS, SSL, and TCP metrics for Apache HttpClient #1617

Open
shakuzen opened this issue Oct 1, 2019 · 2 comments
Open

DNS, SSL, and TCP metrics for Apache HttpClient #1617

shakuzen opened this issue Oct 1, 2019 · 2 comments
Labels
enhancement A general enhancement help wanted An issue that a contributor can help us with instrumentation An issue that is related to instrumenting a component module: micrometer-core An issue that is related to our core module
Milestone

Comments

@shakuzen
Copy link
Member

shakuzen commented Oct 1, 2019

Add metrics for:

  1. DNS resolution time (inject custom DnsResolver, delegating to the user-provided resolver, and timing).
  2. SSL handshake time (inject SSLConnectionSocketFactory, delegating).
  3. TCP connect time (also in custom SSLConnectionSocketFactory).

Apply these on custom PoolingHttpClientConnectionManager.

Feedback suggests that DNS resolution/SSL handshake can go up dramatically in noisy neighbor situations.

Originally posted by @jkschneider in #533 (comment)

@sahilkamboj334
Copy link

any update on this imlementaion @shakuzen ? are we planning these ?

@shakuzen
Copy link
Member Author

No update from my side. A pull request may help get this done sooner. See apache/httpcomponents-client#555, which looks like it would be a useful new feature to help with implementing this. We aren't aware of much specific interest in this from our users, so it has not been prioritized. I've added the help wanted label.

@shakuzen shakuzen added help wanted An issue that a contributor can help us with module: micrometer-core An issue that is related to our core module instrumentation An issue that is related to instrumenting a component labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement help wanted An issue that a contributor can help us with instrumentation An issue that is related to instrumenting a component module: micrometer-core An issue that is related to our core module
Projects
None yet
Development

No branches or pull requests

2 participants