Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line ending characters should not be part of a device file #3

Open
LnnrtS opened this issue Nov 2, 2020 · 1 comment
Open

Line ending characters should not be part of a device file #3

LnnrtS opened this issue Nov 2, 2020 · 1 comment
Assignees
@ilg-ul
Labels
bug

Comments

@LnnrtS
Copy link

LnnrtS commented Nov 2, 2020

https://github.com/micro-os-plus/sifive-hifive1-board-xpack/blob/14e975d158f0c8c0191c0ba781280f48665d3770/src/trace-uart.cpp#L95

I would say that is generic functionality not depending on the trace device but on the receiving application. It should be moved to diag-trace
@ilg-ul ilg-ul mentioned this issue Nov 2, 2020
Closed
@ilg-ul ilg-ul self-assigned this Nov 2, 2020
@ilg-ul ilg-ul added the bug label Nov 2, 2020
@ilg-ul
Copy link
Contributor

ilg-ul commented Nov 2, 2020

Right.

micro-os-plus/diag-trace-xpack#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilg-ul ilg-ul

Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ilg-ul @LnnrtS