Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS error when creating dmaster #73

Closed
MarcMichalsky opened this issue Jul 27, 2021 · 8 comments
Closed

NodeJS error when creating dmaster #73

MarcMichalsky opened this issue Jul 27, 2021 · 8 comments

Comments

@MarcMichalsky
Copy link

MarcMichalsky commented Jul 27, 2021

Hi,
I get the following warnings when I create a new dmaster build:

WARNING: Failed to locate command "node". NodeJS (http://nodejs.org/) is required for development of CiviCRM v4.6+.
WARNING: Failed to locate command "npm". NodeJS (http://nodejs.org/) is required for development of CiviCRM v4.6+.

Later the building process fails at this point:

./bin/setup.sh: line 153: npm: command not found

-> full log

Could this be related to issue #68 or PR #69?

@wmortada
Copy link
Contributor

wmortada commented Jul 27, 2021

It sounds related to me but node and npm should be installed (albeit older versions). Have you tried applying #69 to see if that helps?

@MarcMichalsky
Copy link
Author

Hello @wmortada,
I tried your branch wmortada:68-nodejs-outdated with the same result.
-> full log

@MarcMichalsky
Copy link
Author

As a workaround I installed NodeJS and npm manually.

bkb
sudo apt update
sudo apt install npm

@wmortada
Copy link
Contributor

Are you building your own container or using the one from Docker Hub? That branch will only make a difference if you are building your own container. If you could paste the commands you've used we can check.

@wmortada
Copy link
Contributor

I'm wondering if the container on Docker Hub is missing node?

@michaelmcandrew
Copy link
Owner

I can replicate this, unfortunately.

I am presuming that civi-download-tools was not able to actually download node. I am running docker build civicrm and having a look at the output to see what went wrong...

@MarcMichalsky
Copy link
Author

MarcMichalsky commented Jul 28, 2021

Are you building your own container or using the one from Docker Hub? That branch will only make a difference if you are building your own container. If you could paste the commands you've used we can check.

Ouch! Didn't know that, sorry. Building the docker container on your wmortada:68-nodejs-outdated branch fixed the issue. Thanks!

@michaelmcandrew
Copy link
Owner

@MarcMichalsky - see #68 (comment) - a new docker hub should be published overnight now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants