Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail header matching and overriding #1

Open
neoice opened this issue Jan 14, 2015 · 1 comment
Open

Mail header matching and overriding #1

neoice opened this issue Jan 14, 2015 · 1 comment

Comments

@neoice
Copy link

neoice commented Jan 14, 2015

I see your TODO lists "Mail header matching and overriding."

I want to +1 that 😃

if I wanted to take a stab at implementing this as a PR, do you have any tips on where I should start, coding standards to follow, etc?

@mhale
Copy link
Owner

mhale commented Jan 15, 2015

One way to look at it is that the Subject field is in email headers, so header matching is just a generalised form of subject matching.

My plan for implementing matching was to add a MatchHeader function on Filter, with corresponding test coverage. After that, refactoring the subject matching to use the general header matching function would be simple. Storage would require key/value pairs underneath a "Headers" string map on Filter. I was going to leave the Subject field in the UI though, as IMHO it is more user-friendly to have it.

I haven't got a plan for overriding the headers on a Route though.

As far as coding standards goes, I just try to keep functions small, and run go fmt on the files before I commit them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants