Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes, SMARTS return a TypeError for the TestResults #21

Open
MiCurry opened this issue Jun 17, 2021 · 0 comments
Open

Sometimes, SMARTS return a TypeError for the TestResults #21

MiCurry opened this issue Jun 17, 2021 · 0 comments

Comments

@MiCurry
Copy link
Collaborator

MiCurry commented Jun 17, 2021

Traceback (most recent call last):
  File "/glade/u/home/mcurry/SMARTS2/smarts.py", line 251, in <module>
    args.func(args)
  File "/glade/u/home/mcurry/SMARTS2/smarts.py", line 149, in run_cmd
    test_handler.run_tests(tests, env)
  File "/glade/u/home/mcurry/SMARTS2/smarts/testManager.py", line 511, in run_tests
    ' - "'+test.result.msg+'"\n')
TypeError: can only concatenate str (not "NoneType") to str

I belive this happens when a test fails and does not set result.msg. We just need to handle concatinating NoneType. Its okay if a tests result.msg is a NoneType, but it should not clobber the messages of other tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant