You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is part of #807. Metrics Graphics is a really large library, and one that is largely tested visually. Total nightmare. Refactoring and pushing toward more testable, cleaner code (#811) requires refactoring to deal with smaller code chunks, removing side effects, and thoroughly writing tests around the smaller quantities.
The first step should be straightforward - let's set up a jest-test script for now (so it doesn't clash with the current test script) and begin migrating out the tests into that, refactoring as we go. We can begin populating a jest-test directory until we feel we have comparably bleak coverage, and then replace qunit altogether.
@wlach if this sounds good to you I can make a PR that accomplishes this.
The text was updated successfully, but these errors were encountered:
This is part of #807. Metrics Graphics is a really large library, and one that is largely tested visually. Total nightmare. Refactoring and pushing toward more testable, cleaner code (#811) requires refactoring to deal with smaller code chunks, removing side effects, and thoroughly writing tests around the smaller quantities.
The first step should be straightforward - let's set up a
jest-test
script for now (so it doesn't clash with the currenttest
script) and begin migrating out the tests into that, refactoring as we go. We can begin populating ajest-test
directory until we feel we have comparably bleak coverage, and then replace qunit altogether.@wlach if this sounds good to you I can make a PR that accomplishes this.
The text was updated successfully, but these errors were encountered: