Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write timestep split contour files #1484

Open
wants to merge 4 commits into
base: main-dev
Choose a base branch
from
Open

Write timestep split contour files #1484

wants to merge 4 commits into from

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Jan 16, 2025 •
edited
Loading

Change Summary

  • Writes contour files as separate files, split by timestep.
  • Removes "legend" entry in contour which is obsolete.

Related issue number

closes #1481

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.46%. Comparing base (92163d4) to head (1a664f9).
Report is 1 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/aeroval/modelmaps_helpers.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           main-dev    #1484      +/-   ##
============================================
- Coverage     78.46%   78.46%   -0.01%     
============================================
  Files           139      139              
  Lines         21120    21119       -1     
============================================
- Hits          16571    16570       -1     
  Misses         4549     4549
Flag Coverage Δ
unittests 78.46% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl force-pushed the write-timestep-split-contour-files branch from 40453e8 to 1a664f9 Compare January 17, 2025 08:19
@thorbjoernl thorbjoernl added this to the m2025-02 milestone Jan 17, 2025
@thorbjoernl thorbjoernl marked this pull request as ready for review January 17, 2025 08:32
@thorbjoernl thorbjoernl self-assigned this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewisblake lewisblake Awaiting requested review from lewisblake

At least 1 approving review is required to merge this pull request.

Assignees

@thorbjoernl thorbjoernl

Labels
None yet
Projects
None yet
Milestone
m2025-02
Development

Successfully merging this pull request may close these issues.

Write contour files as timestep-split files
1 participant
@thorbjoernl