Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors are no longer showing up for my app but performance monitoring is still working. #242

Closed
mjgallag opened this issue Jul 6, 2016 · 2 comments

Comments

@mjgallag
Copy link

mjgallag commented Jul 6, 2016

I have the latest version of this package 2.29.1 and the latest version of meteor 1.3.4.1.

I tried restarted my app's container on galaxy and all looks good:

6s55 2016-07-06 14:04:05-07:00 Application process starting, version: 30 on apprunner mdg0/apprunner:20160606T225805Z_86c9deb
6s55 2016-07-06 14:04:19-07:00 Kadira: completed instrumenting the app
6s55 2016-07-06 14:04:19-07:00 Kadira: Successfully connected

But throw new Error('TEST'); doesn't ever show up in Kadira.

Thanks in advance for your help @arunoda.

@arunoda
Copy link
Member

arunoda commented Jul 6, 2016

How do you throw the error? Via browser console.
If so, try to do this like this:

setTimeout(function() {
   throw new Error('TEST');
}, 0);

@mjgallag
Copy link
Author

mjgallag commented Jul 6, 2016

Ah ha, that works, thanks. Sorry for the false alarm, I thought it was a valid test to throw an error in browser console without the setTimeout.

I got a bit thrown off because I was fixing an unhandled exception in an autoValue function of mine that AutoForm caught and wrote to console.error, but didn't then re-throw. I now understand that Kadira won't pick up console.error writes.
https://github.com/aldeed/meteor-autoform/blob/devel/autoform-events.js#L309

@mjgallag mjgallag closed this as completed Jul 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants