Deprecate NoCloudProvider and add CloudProviderEnabled

[adilGhaffarDev]

Deprecate NoCloudProvider and add CloudProviderEnabled to avoid double negation.

• NoCloudProvider defaults to false. This is problematic because CAPM3's default behavior should not assume that a cloud provider is deployed. It has been there since it was implemented.

• Now we should add CloudProviderEnabled and slowly deprecate NoCloudProvider.

The problem in adding CloudProviderEnabled:
CloudProviderEnabled will also default to false, and now both will contradict if not set by the user.

Proposed solution:

• Deprecate NoCloudProvider now(this release cycle 1.10), add CloudProviderEnabled, and set the default value of CloudProviderEnabled to true.
• Next release cycle(1.11), remove NoCloudProvider.
• Next release cycle(1.12) we can remove the default true value of CloudProviderEnabled.

[tuminoid]

Proposed solution sounds good to me.

[adilGhaffarDev]

Tagging the release team here, FYI
@mquhuy @peppi-lotta @Rozzii

[Rozzii]

/triage accepted

[tuminoid]

/assign @adilGhaffarDev

[tuminoid]

This work has effect on dev-env too. Tests are broken right now: metal3-io/metal3-dev-env#1499

[adilGhaffarDev]

This work has effect on dev-env too. Tests are broken right now: metal3-io/metal3-dev-env#1499

this PR should fix it : #2276

[Rozzii]

The proposed fix has been merged, can this ticket be closed @adilGhaffarDev ?

[adilGhaffarDev]

The proposed fix has been merged, can this ticket be closed @adilGhaffarDev ?

No because this ticket is tracking other work that is scheduled to be done in release 1.11 and 1.12 cycle.