Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a smart waiter for start swap method when no loaded balance #47

Open
5 tasks
Andrew718PLTS opened this issue Dec 16, 2024 · 1 comment
Open
5 tasks
Assignees

Comments

@Andrew718PLTS
Copy link
Collaborator

Description

During testing the all swap tests we saw that sometimes after wallet connection balance can be not loaded because of RPC - therefore we have some failures. In the scope of this ticket, it has to be handled by the waiter of loaded balance, if there is no loaded balance - we should wait for and only when it's there start the swapping execution.

Acceptance Criteria

  • Start method updated with new smart waiter for loaded balance

  • Tested all new/updated changes
  • Autotests passed locally
  • Autotests passed on the CI
  • Added/Updated a documentation

Attachments

@Andrew718PLTS
Copy link
Collaborator Author

After investigation I defined that currently we can define a connected wallet only by displayed balances of tokens from the settings popup - without custom locator there are no a valid selector to verify it. Previously, in the scope of another ticket I already added custom locators for balances.
@bayological could you tell me please when you'll release that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant