Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for google vector search - (matching engine) #2177

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

anchit-nishant
Copy link

Description

Adding support for google vector search (matching engine).
m.add | m.get | m.get_all | m.update | m.search | m.history | m.delete |

Type of change

  • New feature (non-breaking change which adds functionality)
  • Documentation update

How Has This Been Tested?

Manual testing. with below parameters.
"vector_store": {
"provider": "google_matching_engine",
"config": {
"endpoint_id": "XXXXXXXXXXXXXXXXXXX",
"index_id": "XXXXXXXXXXXXXXXXXXX",
"deployment_index_id": "abc_XXXXXXXXXXXXX",
"project_id": "",
"project_number": "XXXXXXXXXXXX",
"region": "us-central1",
"vector_search_api_endpoint": "XXXXXXXXX.us-central1-XXXXXXXXXXXX.vdb.vertexai.goog"
}

  • Manual testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

Sorry, something went wrong.

@Dev-Khant
Copy link
Member

Hey @anchit-nishant Can you please resolve the merge conflicts and so then we can review the PR?

@anchit-nishant
Copy link
Author

Hey @Dev-Khant
Have merged the conflicts. Please let me know if you have any feedback.

@Dev-Khant
Copy link
Member

Hey @anchit-nishant I think we got a new merge conflict because of a PR was merged, can you please resolve it?

Copy link
Member

@Dev-Khant Dev-Khant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be good to call it vertex_ai_search?

@anchit-nishant
Copy link
Author

Merged.

Vertex AI Search is a an end to end search solution from GCP, where as Vertex AI Vector Search (earlier called as Matching Engine) is a Vector Database provided by GCP. We are using Vector Search (Matching Engine) here

@Dev-Khant
Copy link
Member

Merged.

Vertex AI Search is a an end to end search solution from GCP, where as Vertex AI Vector Search (earlier called as Matching Engine) is a Vector Database provided by GCP. We are using Vector Search (Matching Engine) here

Got it, thanks for clarifying. Then we should name it as vertex_ai_vector_search because users would search google_matching_engine and they will be redirect to vector search docs. It would be confusing, as I myself faced it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants