Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getting configuration of API client from arguments on all embedder. #2145

Open
elda27 opened this issue Jan 14, 2025 · 0 comments
Open

Comments

@elda27
Copy link

elda27 commented Jan 14, 2025

🚀 The feature

Some embedder lacks configuration from arguments.
For example, AzureOpenAIEmbedder doesn't deliver to its API client.
https://github.com/mem0ai/mem0/blob/3fa4b80debc6e741c89948b66db7283fbf6ed2e7/embedchain/embedchain/embedder/azure_openai.py#L17C22-L17C43

Motivation, pitch

Similarly issue is discussed on #1706, its change can configure all parameters of LLMs from arguments now.
Embedder needs to set API key or endpoint by workaround using os.environ now.
I would like to set these parameters without this workaround for security and easy to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant