Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Think about reintroducing the MDB_IDL_LOGN features #139

Closed
Kerollmops opened this issue Dec 23, 2022 · 1 comment
Closed

Think about reintroducing the MDB_IDL_LOGN features #139

Kerollmops opened this issue Dec 23, 2022 · 1 comment
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@Kerollmops
Copy link
Member

The Mozilla team changed the midl.h file and made the MDB_IDL_LOGN define customizable using a Cargo TOML feature. This change was made to reduce the number of free pages when opening a database in read-write mode.

A bunch of questions for this issue to be closed:

  1. Do we care about this parameter for Meilisearch?
  2. Do other companies need this?
  3. Should we reintroduce this patch to the LMDB source code?
  4. Should hyc introduce the #ifndef #endif changes in the official source code?
@Kerollmops Kerollmops added help wanted Extra attention is needed question Further information is requested labels Dec 23, 2022
@Kerollmops Kerollmops changed the title Think about reintroducing the MDB_IDL features Think about reintroducing the MDB_IDL_LOGN features Nov 26, 2023
@Kerollmops
Copy link
Member Author

Implemented by #229.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Kerollmops