Merge pull request #246 from hinto-janai/open

Set `EnvOpenOptions::open()` to `unsafe`
meilisearch · Mar 4, 2024 · 029a25b · 029a25b
2 parents 1372597 + cda37c6
commit 029a25b
Show file tree

Hide file tree

Showing 13 changed files with 360 additions and 222 deletions.
diff --git a/heed/examples/all-types.rs b/heed/examples/all-types.rs
@@ -12,10 +12,12 @@ fn main() -> Result<(), Box<dyn Error>> {
 
     fs::create_dir_all(&path)?;
 
-    let env = EnvOpenOptions::new()
-        .map_size(10 * 1024 * 1024) // 10MB
-        .max_dbs(3000)
-        .open(path)?;
+    let env = unsafe {
+        EnvOpenOptions::new()
+            .map_size(10 * 1024 * 1024) // 10MB
+            .max_dbs(3000)
+            .open(path)?
+    };
 
     // here the key will be an str and the data will be a slice of u8
     let mut wtxn = env.write_txn()?;

diff --git a/heed/examples/clear-database.rs b/heed/examples/clear-database.rs
@@ -13,10 +13,12 @@ fn main() -> Result<(), Box<dyn Error>> {
     let _ = fs::remove_dir_all(&env_path);
 
     fs::create_dir_all(&env_path)?;
-    let env = EnvOpenOptions::new()
-        .map_size(10 * 1024 * 1024) // 10MB
-        .max_dbs(3)
-        .open(env_path)?;
+    let env = unsafe {
+        EnvOpenOptions::new()
+            .map_size(10 * 1024 * 1024) // 10MB
+            .max_dbs(3)
+            .open(env_path)?
+    };
 
     let mut wtxn = env.write_txn()?;
     let db: Database<Str, Str> = env.create_database(&mut wtxn, Some("first"))?;

diff --git a/heed/examples/cursor-append.rs b/heed/examples/cursor-append.rs
@@ -13,10 +13,12 @@ fn main() -> Result<(), Box<dyn Error>> {
     let _ = fs::remove_dir_all(&env_path);
 
     fs::create_dir_all(&env_path)?;
-    let env = EnvOpenOptions::new()
-        .map_size(10 * 1024 * 1024) // 10MB
-        .max_dbs(3)
-        .open(env_path)?;
+    let env = unsafe {
+        EnvOpenOptions::new()
+            .map_size(10 * 1024 * 1024) // 10MB
+            .max_dbs(3)
+            .open(env_path)?
+    };
 
     let mut wtxn = env.write_txn()?;
     let first: Database<Str, Str> = env.create_database(&mut wtxn, Some("first"))?;

diff --git a/heed/examples/custom-comparator.rs b/heed/examples/custom-comparator.rs
@@ -26,10 +26,12 @@ fn main() -> Result<(), Box<dyn Error>> {
     let _ = fs::remove_dir_all(&env_path);
 
     fs::create_dir_all(&env_path)?;
-    let env = EnvOpenOptions::new()
-        .map_size(10 * 1024 * 1024) // 10MB
-        .max_dbs(3)
-        .open(env_path)?;
+    let env = unsafe {
+        EnvOpenOptions::new()
+            .map_size(10 * 1024 * 1024) // 10MB
+            .max_dbs(3)
+            .open(env_path)?
+    };
 
     let mut wtxn = env.write_txn()?;
     let db = env

diff --git a/heed/examples/multi-env.rs b/heed/examples/multi-env.rs
@@ -13,16 +13,20 @@ fn main() -> Result<(), Box<dyn Error>> {
     let env2_path = Path::new("target").join("env2.mdb");
 
     fs::create_dir_all(&env1_path)?;
-    let env1 = EnvOpenOptions::new()
-        .map_size(10 * 1024 * 1024) // 10MB
-        .max_dbs(3000)
-        .open(env1_path)?;
+    let env1 = unsafe {
+        EnvOpenOptions::new()
+            .map_size(10 * 1024 * 1024) // 10MB
+            .max_dbs(3000)
+            .open(env1_path)?
+    };
 
     fs::create_dir_all(&env2_path)?;
-    let env2 = EnvOpenOptions::new()
-        .map_size(10 * 1024 * 1024) // 10MB
-        .max_dbs(3000)
-        .open(env2_path)?;
+    let env2 = unsafe {
+        EnvOpenOptions::new()
+            .map_size(10 * 1024 * 1024) // 10MB
+            .max_dbs(3000)
+            .open(env2_path)?
+    };
 
     let mut wtxn1 = env1.write_txn()?;
     let mut wtxn2 = env2.write_txn()?;

diff --git a/heed/examples/nested.rs b/heed/examples/nested.rs
@@ -10,10 +10,12 @@ fn main() -> Result<(), Box<dyn Error>> {
 
     fs::create_dir_all(&path)?;
 
-    let env = EnvOpenOptions::new()
-        .map_size(10 * 1024 * 1024) // 10MB
-        .max_dbs(3000)
-        .open(path)?;
+    let env = unsafe {
+        EnvOpenOptions::new()
+            .map_size(10 * 1024 * 1024) // 10MB
+            .max_dbs(3000)
+            .open(path)?
+    };
 
     // here the key will be an str and the data will be a slice of u8
     let mut wtxn = env.write_txn()?;

diff --git a/heed/examples/rmp-serde.rs b/heed/examples/rmp-serde.rs
@@ -11,10 +11,12 @@ fn main() -> Result<(), Box<dyn Error>> {
 
     fs::create_dir_all(&path)?;
 
-    let env = EnvOpenOptions::new()
-        .map_size(10 * 1024 * 1024) // 10MB
-        .max_dbs(3000)
-        .open(path)?;
+    let env = unsafe {
+        EnvOpenOptions::new()
+            .map_size(10 * 1024 * 1024) // 10MB
+            .max_dbs(3000)
+            .open(path)?
+    };
 
     // you can specify that a database will support some typed key/data
     // serde types are also supported!!!