Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does the plugin try to rename the machine when I haven't asked it to? #24

Open
pauby opened this issue Aug 14, 2018 · 4 comments
Open

Comments

@pauby
Copy link

pauby commented Aug 14, 2018

Running a Vagrant machine with this configuration:

# Run Windows Domain Provisioner
client.vm.provision :windows_domain do |domain|
    # The Windows Domain to join.
    domain.domain = "test.local"
    # The new Computer Name to use when joining the domain.
    #domain.computer_name = "client"
    # The Username to use when authenticating against the Domain.
    domain.username = "test\\administrator"
    # The Password to use when authenticating against the Domain.
    domain.password = "xxxxxxxx"
    # The set of Advanced options to pass when joining the Domain.
    #domain.join_options = [ "JoinReadOnly" ]
    # Organisational Unit path in AD.
    #domain.ou_path = "OU=testOU,DC=domain,DC=Domain,DC=com"
    # Performs an unsecure join to the specified domain.
    #domain.unsecure = false
end

Note that I have commented out the value to rename the computer. But it results in:

image

Why is it trying to rename the computer?

@mefellows
Copy link
Owner

It might be a bug, renaming should probably be optional but perhaps in the last few updates a regression came through (or perhaps it was never a consideration when I first created it).

Would you be willing to get your hands dirty to resolve?

@pauby
Copy link
Author

pauby commented Aug 16, 2018

@mefellows I would be happy to get my hands dirty. I have a huge time issue in doing so (as we all do) as I'm working on another few projects. But I have added it to my ever growing to do list. Hopefully I can get to it before somebody else does!

@pauby
Copy link
Author

pauby commented Jul 8, 2019

@thelastofreed This issue is almost a year old now but I do appreciate you responding. I'm not sure if what you say will work or not and I'm not in a position to test it. However the environment this issue was raised in still does exist even though it's been dormamt for a while now. If I get time I will blow the dust off of it and try it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
@mefellows @pauby and others