Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User defined export default in .mdx should be allowed #362

Closed
4 tasks done
JounQin opened this issue Dec 11, 2023 · 3 comments · Fixed by #365
Closed
4 tasks done

User defined export default in .mdx should be allowed #362

JounQin opened this issue Dec 11, 2023 · 3 comments · Fixed by #365
Labels
🗄 area/interface This affects the public interface 👍 phase/yes Post is accepted and can be worked on 🐛 type/bug This is a problem 🙆 yes/confirmed This is confirmed and ready to be worked on

Comments

@JounQin
Copy link
Member

JounQin commented Dec 11, 2023

Initial checklist

Affected packages and versions

vscode-mdx

Link to runnable example

No response

Steps to reproduce

export   default     ({children   }) => < div> Content {    children}</div>

Run on https://mdxjs.com/playground/

Expected behavior

image

Actual behavior

image

Runtime

Node v20

Package manager

yarn v1

OS

macOS

Build and bundle tools

Rollup

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Dec 11, 2023
@remcohaszing remcohaszing added 🐛 type/bug This is a problem 🛠 blocked/wip This cannot progress yet, it’s being worked on 🙆 yes/confirmed This is confirmed and ready to be worked on 👍 phase/yes Post is accepted and can be worked on labels Dec 11, 2023
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Dec 11, 2023
Copy link
Contributor

Hi! This was marked as ready to be worked on! Note that while this is ready to be worked on, nothing is said about priority: it may take a while for this to be solved.

Is this something you can and want to work on?

Team: please use the area/* (to describe the scope of the change), platform/* (if this is related to a specific one), and semver/* and type/* labels to annotate this. If this is first-timers friendly, add good first issue and if this could use help, add help wanted.

@remcohaszing
Copy link
Member

Ah yes, I can see why this happens. I’m reworking virtual files internally to make them more flexible. This will open up the possibility to fix this.

@remcohaszing remcohaszing added 🗄 area/interface This affects the public interface and removed 🛠 blocked/wip This cannot progress yet, it’s being worked on labels Dec 11, 2023
remcohaszing added a commit that referenced this issue Dec 11, 2023
@remcohaszing remcohaszing mentioned this issue Dec 11, 2023
5 tasks
remcohaszing added a commit that referenced this issue Dec 12, 2023
remcohaszing added a commit that referenced this issue Dec 12, 2023
remcohaszing added a commit that referenced this issue Dec 14, 2023
Copy link
Contributor

Hi! This was closed. Team: If this was fixed, please add phase/solved. Otherwise, please add one of the no/* labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 👍 phase/yes Post is accepted and can be worked on 🐛 type/bug This is a problem 🙆 yes/confirmed This is confirmed and ready to be worked on
Development

Successfully merging a pull request may close this issue.

2 participants