-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set operation Venn diagram images 404 #12456
Comments
@mdn/core-dev does it have anything to do with platform changes? We often use relative paths like |
@mdn/core-dev |
@Benricheson101 @Josh-Cena I discussed this issue with @fiji-flo, and it looks like the relative paths aren't correct in content, because they don't align with MDN's public URL structure: Since the page https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set has no trailing slash, the correct path to the child page is |
This has worked before and all of the relative paths on MDN assume that the URLs have a trailing slash, so it seems easier to preserve backward compatibility, unless a straightforward way exists to collect all such relative paths? |
This should be fixed: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set |
There's a similar issue here: mdn/content#37645 so it seems that |
MDN URL
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set
What specific section or headline is this issue about?
Set composition
What information was incorrect, unhelpful, or incomplete?
The linked images meant to show Venn diagrams 404. They appear to use (incorrect) relative paths instead of absolute paths like the same images do on each set function's page.
What did you expect to see?
The image links should link to the correct path.
Incorrect (current): https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/union/diagram.svg
Correct: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/union/diagram.svg
Do you have any supporting links, references, or citations?
I haven't been able to reproduce the issue locally using
yarn start
, but after some digging on archive.org it seems to have worked up until sometime between 01:49:04 and 19:25:16 on December 17, 2024.The src= path in the HTML appears to be a relative link, whereas the rest of the images (including the same images on each Set methods' pages) use absolute paths.
Do you have anything more you want to share?
No response
MDN metadata
Page report details
en-us/web/javascript/reference/global_objects/set
The text was updated successfully, but these errors were encountered: