Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set operation Venn diagram images 404 #12456

Open
Benricheson101 opened this issue Dec 27, 2024 · 6 comments
Open

Set operation Venn diagram images 404 #12456

Benricheson101 opened this issue Dec 27, 2024 · 6 comments
Labels
needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.

Comments

@Benricheson101
Copy link

MDN URL

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set

What specific section or headline is this issue about?

Set composition

What information was incorrect, unhelpful, or incomplete?

The linked images meant to show Venn diagrams 404. They appear to use (incorrect) relative paths instead of absolute paths like the same images do on each set function's page.

What did you expect to see?

The image links should link to the correct path.

Incorrect (current): https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/union/diagram.svg
Correct: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/union/diagram.svg

Do you have any supporting links, references, or citations?

I haven't been able to reproduce the issue locally using yarn start, but after some digging on archive.org it seems to have worked up until sometime between 01:49:04 and 19:25:16 on December 17, 2024.

The src= path in the HTML appears to be a relative link, whereas the rest of the images (including the same images on each Set methods' pages) use absolute paths.

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@Benricheson101 Benricheson101 added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Dec 27, 2024
@Josh-Cena
Copy link
Member

@mdn/core-dev does it have anything to do with platform changes? We often use relative paths like src="intersection/diagram.svg" and on the location https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set it used to resolve to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/intersection/diagram.svg.

@Josh-Cena Josh-Cena removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Dec 28, 2024
@Josh-Cena
Copy link
Member

@mdn/core-dev

@bsmth bsmth transferred this issue from mdn/content Jan 15, 2025
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jan 15, 2025
@caugner
Copy link
Contributor

caugner commented Jan 16, 2025

@Benricheson101 @Josh-Cena I discussed this issue with @fiji-flo, and it looks like the relative paths aren't correct in content, because they don't align with MDN's public URL structure:

Since the page https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set has no trailing slash, the correct path to the child page is Set/difference, so those images are missing the Set/ prefix.

@Josh-Cena
Copy link
Member

This has worked before and all of the relative paths on MDN assume that the URLs have a trailing slash, so it seems easier to preserve backward compatibility, unless a straightforward way exists to collect all such relative paths?

@fiji-flo
Copy link
Contributor

@Josh-Cena
Copy link
Member

There's a similar issue here: mdn/content#37645 so it seems that <img> paths are resolved correctly but not <a> href?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.
Projects
None yet
Development

No branches or pull requests

4 participants