Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider remove SecurePaymentConfirmationRequest dictionary #31287

Closed
skyclouds2001 opened this issue Dec 25, 2023 · 6 comments
Closed

Consider remove SecurePaymentConfirmationRequest dictionary #31287

skyclouds2001 opened this issue Dec 25, 2023 · 6 comments
Labels
needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.

Comments

@skyclouds2001
Copy link
Contributor

MDN URL

'

What specific section or headline is this issue about?

No response

What information was incorrect, unhelpful, or incomplete?

added in #30439 and previously #28705

but I wonder if this SecurePaymentConfirmationRequest dictionary should be kept in a separate page, because the structure seems to be only used in PaymentRequest() constructor

What did you expect to see?

as above

Do you have any supporting links, references, or citations?

the spec https://w3c.github.io/secure-payment-confirmation/

mdn content update #28705 #30439

BCD data update mdn/browser-compat-data#20583 and mdn/browser-compat-data#21460

mdn task mdn/mdn#421

Do you have anything more you want to share?

No response

@skyclouds2001 skyclouds2001 added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Dec 25, 2023
@skyclouds2001 skyclouds2001 changed the title SecurePaymentConfirmationRequest dictionary Consider remove SecurePaymentConfirmationRequest dictionary Dec 27, 2023
@wbamberg
Copy link
Collaborator

Well since I suggested adding this, I'll explain why I did. https://developer.mozilla.org/en-US/docs/Web/API/PaymentRequest/PaymentRequest#parameters is already a ferociously complicated section, and adding the contents of https://developer.mozilla.org/en-US/docs/Web/API/SecurePaymentConfirmationRequest inline into it would IMO make this really hard for people to follow. So I think the docs are more usable with it split out into a separate page.

@teoli2003
Copy link
Contributor

I'm not against keeping this page.

Do we have a place to list dictionaries we decided to keep? (and the one we still have to remove?) (Maybe @hamishwillee knows it)

@skyclouds2001
Copy link
Contributor Author

I wonder if it is possible to add a new page-type key like web-api-dictionary, to separate from web-api-interface. CUrrently it is not easy to separate pages of dictionary from interface

@teoli2003
Copy link
Contributor

Yes, we want to do this (only on dictionaries we decide to keep).

I don't remember what we need to do to add it. @wbamberg will.

@wbamberg
Copy link
Collaborator

wbamberg commented Jan 9, 2024

We discussed this, and didn't, because we don't treat interfaces differently from dictionaries, and because we don't think user see them as different things. And sometimes the distinction can feel quite artificial: for example, PerformanceEntry is technically an interface because it is JSON-serializable, so it defines a toJSON() method as a helper for JSON.stringify(). But PerformanceEntry feels, to me at any rate, to be essentially just data, like a dictionary.

I'm just providing this to explain that we have considered this before, and this was the reasoning. Maybe we should change. I don't feel particularly strongly. Usually we have page types when we want to treat things differently, and in particular if we want them to have different page templates. Maybe if dictionaries never have BCD, that amounts to a big enough difference.

I don't remember what we need to do to add it. @wbamberg will.

We add it to https://developer.mozilla.org/en-US/docs/MDN/Writing_guidelines/Page_structures/Page_types/Page_type_key#web_api_page_types and, ideally, write a corresponding template.

@wbamberg
Copy link
Collaborator

wbamberg commented Apr 9, 2024

I'm closing this because I think we should keep https://developer.mozilla.org/en-US/docs/Web/API/SecurePaymentConfirmationRequest as a separate page, and haven't made the case for a new dictionary page type. If people feel strongly, let's have a discussion about either or both of these.

@wbamberg wbamberg closed this as not planned Won't fix, can't repro, duplicate, stale Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.
Projects
None yet
Development

No branches or pull requests

3 participants