-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider remove SecurePaymentConfirmationRequest
dictionary
#31287
Comments
SecurePaymentConfirmationRequest
dictionarySecurePaymentConfirmationRequest
dictionary
Well since I suggested adding this, I'll explain why I did. https://developer.mozilla.org/en-US/docs/Web/API/PaymentRequest/PaymentRequest#parameters is already a ferociously complicated section, and adding the contents of https://developer.mozilla.org/en-US/docs/Web/API/SecurePaymentConfirmationRequest inline into it would IMO make this really hard for people to follow. So I think the docs are more usable with it split out into a separate page. |
I'm not against keeping this page. Do we have a place to list dictionaries we decided to keep? (and the one we still have to remove?) (Maybe @hamishwillee knows it) |
I wonder if it is possible to add a new |
Yes, we want to do this (only on dictionaries we decide to keep). I don't remember what we need to do to add it. @wbamberg will. |
We discussed this, and didn't, because we don't treat interfaces differently from dictionaries, and because we don't think user see them as different things. And sometimes the distinction can feel quite artificial: for example, I'm just providing this to explain that we have considered this before, and this was the reasoning. Maybe we should change. I don't feel particularly strongly. Usually we have page types when we want to treat things differently, and in particular if we want them to have different page templates. Maybe if dictionaries never have BCD, that amounts to a big enough difference.
We add it to https://developer.mozilla.org/en-US/docs/MDN/Writing_guidelines/Page_structures/Page_types/Page_type_key#web_api_page_types and, ideally, write a corresponding template. |
I'm closing this because I think we should keep https://developer.mozilla.org/en-US/docs/Web/API/SecurePaymentConfirmationRequest as a separate page, and haven't made the case for a new dictionary page type. If people feel strongly, let's have a discussion about either or both of these. |
MDN URL
'
What specific section or headline is this issue about?
No response
What information was incorrect, unhelpful, or incomplete?
added in #30439 and previously #28705
but I wonder if this
SecurePaymentConfirmationRequest
dictionary should be kept in a separate page, because the structure seems to be only used inPaymentRequest()
constructorWhat did you expect to see?
as above
Do you have any supporting links, references, or citations?
the spec https://w3c.github.io/secure-payment-confirmation/
mdn content update #28705 #30439
BCD data update mdn/browser-compat-data#20583 and mdn/browser-compat-data#21460
mdn task mdn/mdn#421
Do you have anything more you want to share?
No response
The text was updated successfully, but these errors were encountered: