From f8c7cf9095e67f42c68a5519022d566a49a843a4 Mon Sep 17 00:00:00 2001
From: Petar Pejovic <108530920+petar-qb@users.noreply.github.com>
Date: Tue, 14 Nov 2023 11:12:24 +0100
Subject: [PATCH] Fixed vm.Slider and vm.RangeSlider to work with incorrect
 text input (#173)

---
 ...tar_pejovic_fix_sliders_incorrect_input.md | 47 +++++++++++++++++++
 .../vizro/static/js/models/range_slider.js    |  3 ++
 .../src/vizro/static/js/models/slider.js      |  3 ++
 3 files changed, 53 insertions(+)
 create mode 100644 vizro-core/changelog.d/20231114_095856_petar_pejovic_fix_sliders_incorrect_input.md

diff --git a/vizro-core/changelog.d/20231114_095856_petar_pejovic_fix_sliders_incorrect_input.md b/vizro-core/changelog.d/20231114_095856_petar_pejovic_fix_sliders_incorrect_input.md
new file mode 100644
index 000000000..f0518fa2d
--- /dev/null
+++ b/vizro-core/changelog.d/20231114_095856_petar_pejovic_fix_sliders_incorrect_input.md
@@ -0,0 +1,47 @@
+<!--
+A new scriv changelog fragment.
+
+Uncomment the section that is right (remove the HTML comment wrapper).
+-->
+
+<!--
+### Highlights ✨
+
+- A bullet item for the Highlights ✨ category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
+
+-->
+<!--
+### Removed
+
+- A bullet item for the Removed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
+
+-->
+<!--
+### Added
+
+- A bullet item for the Added category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
+
+-->
+<!--
+### Changed
+
+- A bullet item for the Changed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
+
+-->
+<!--
+### Deprecated
+
+- A bullet item for the Deprecated category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
+
+-->
+
+### Fixed
+
+- Fixed `vm.Slider` and `vm.RangeSlider` to work with incorrect text input. ([#173](https://github.com/mckinsey/vizro/pull/173))
+
+<!--
+### Security
+
+- A bullet item for the Security category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
+
+-->
diff --git a/vizro-core/src/vizro/static/js/models/range_slider.js b/vizro-core/src/vizro/static/js/models/range_slider.js
index fe45382ec..94e877368 100644
--- a/vizro-core/src/vizro/static/js/models/range_slider.js
+++ b/vizro-core/src/vizro/static/js/models/range_slider.js
@@ -21,6 +21,9 @@ export function _update_range_slider_values(
     trigger_id === `${self_data["id"]}_start_value` ||
     trigger_id === `${self_data["id"]}_end_value`
   ) {
+    if (isNaN(start) || isNaN(end)) {
+      return dash_clientside.no_update;
+    }
     [start_text_value, end_text_value] = [start, end];
   } else if (trigger_id === self_data["id"]) {
     [start_text_value, end_text_value] = [slider[0], slider[1]];
diff --git a/vizro-core/src/vizro/static/js/models/slider.js b/vizro-core/src/vizro/static/js/models/slider.js
index 3dffc3c0f..d467706b5 100644
--- a/vizro-core/src/vizro/static/js/models/slider.js
+++ b/vizro-core/src/vizro/static/js/models/slider.js
@@ -7,6 +7,9 @@ export function _update_slider_values(start, slider, input_store, self_data) {
       dash_clientside.callback_context.triggered[0]["prop_id"].split(".")[0];
   }
   if (trigger_id === `${self_data["id"]}_text_value`) {
+    if (isNaN(start)) {
+      return dash_clientside.no_update;
+    }
     text_value = start;
   } else if (trigger_id === self_data["id"]) {
     text_value = slider;