From c1a92deda4e3fd096bd1358de7ce26773c83ee93 Mon Sep 17 00:00:00 2001 From: Antony Milne Date: Wed, 25 Oct 2023 15:45:46 +0100 Subject: [PATCH] Remove comments --- .github/workflows/check-release.yml | 4 ---- .github/workflows/lint-vizro-core.yml | 2 +- vizro-core/hatch.toml | 18 ++++++------------ 3 files changed, 7 insertions(+), 17 deletions(-) diff --git a/.github/workflows/check-release.yml b/.github/workflows/check-release.yml index c40fed3b1..53d8eaca3 100644 --- a/.github/workflows/check-release.yml +++ b/.github/workflows/check-release.yml @@ -118,7 +118,3 @@ jobs: ./../tools/version-bump.sh mckinsey vizro ${{ secrets.GITHUB_TOKEN }} \ ${{needs.check-version.outputs.package_name}} \ ${{needs.check-version.outputs.package_version}} release/version_bump_next_minor/${formatted_date} - -# automate merging of this? -# why need lint here? -# does github release notes automatically? Why not scriv github-release? \ No newline at end of file diff --git a/.github/workflows/lint-vizro-core.yml b/.github/workflows/lint-vizro-core.yml index c6a9b2372..76754e2cc 100644 --- a/.github/workflows/lint-vizro-core.yml +++ b/.github/workflows/lint-vizro-core.yml @@ -30,7 +30,7 @@ jobs: steps: - uses: actions/checkout@v4 with: - fetch-depth: ${{ github.event_name == 'pull_request' && 2 || 0 }} #why? + fetch-depth: ${{ github.event_name == 'pull_request' && 2 || 0 }} - name: Set up Python ${{ matrix.python-version }} uses: actions/setup-python@v4 diff --git a/vizro-core/hatch.toml b/vizro-core/hatch.toml index 23b26ec7a..903e3d01b 100644 --- a/vizro-core/hatch.toml +++ b/vizro-core/hatch.toml @@ -8,6 +8,11 @@ matrix.python.features = [ {value = "kedro", if = ["3.8", "3.9", "3.10"]} ] +[envs.changelog] +dependencies = ["scriv"] +detached = true +scripts = {add = "scriv create --add"} + [envs.default] dependencies = [ "devtools[pygments]", @@ -37,11 +42,6 @@ cov-report = [ ] example = "cd examples/{args:default}; python app.py" lint = "SKIP=gitleaks pre-commit run {args} --all-files" -post-release = [ - "hatch version patch,dev", - "echo 'Raise a PR to bump to the new development version'" -] # No longer needed? - prep-release = [ "hatch version release", "hatch run changelog:scriv collect --add", @@ -49,7 +49,7 @@ prep-release = [ "schema", "hatch run lint || hatch run lint", "hatch run changelog:add", - 'echo "Now raise a PR to merge into main with title: Release of vizro-core $(hatch version)"', + 'echo "Now raise a PR to merge into main with title: Release of vizro-core $(hatch version)"' ] pypath = "python -c 'import sys; print(sys.executable)'" schema = "python schemas/generate.py {args}" @@ -80,12 +80,6 @@ dependencies = [ detached = true scripts = {serve = "mkdocs serve"} -[envs.changelog] -dependencies = ["scriv"] -detached = true -scripts = {add = "scriv create --add"} - - [publish.index] disable = true