From a3475734a6f22fd33ec287715e435f4ec2c03462 Mon Sep 17 00:00:00 2001 From: huong-li-nguyen Date: Fri, 15 Dec 2023 18:32:43 +0100 Subject: [PATCH] PR comments --- .github/workflows/test-integration-vizro-ai.yml | 2 +- .github/workflows/test-integration-vizro-core.yml | 2 +- .github/workflows/test-unit-vizro-ai.yml | 2 +- .github/workflows/test-unit-vizro-core.yml | 2 +- vizro-core/hatch.toml | 2 +- vizro-core/pyproject.toml | 3 ++- 6 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/test-integration-vizro-ai.yml b/.github/workflows/test-integration-vizro-ai.yml index 1daa3fec8..706be2f1d 100644 --- a/.github/workflows/test-integration-vizro-ai.yml +++ b/.github/workflows/test-integration-vizro-ai.yml @@ -32,7 +32,7 @@ jobs: hatch-env: all.py3.11 - python-version: "3.12" hatch-env: all.py3.12 - - python-version: "3.12" + - python-version: "3.11" hatch-env: lower-bounds label: lower bounds diff --git a/.github/workflows/test-integration-vizro-core.yml b/.github/workflows/test-integration-vizro-core.yml index 9f70e22ad..31fe80a11 100644 --- a/.github/workflows/test-integration-vizro-core.yml +++ b/.github/workflows/test-integration-vizro-core.yml @@ -34,7 +34,7 @@ jobs: hatch-env: all.py3.11 - python-version: "3.12" hatch-env: all.py3.12 - - python-version: "3.12" + - python-version: "3.11" hatch-env: lower-bounds label: lower bounds diff --git a/.github/workflows/test-unit-vizro-ai.yml b/.github/workflows/test-unit-vizro-ai.yml index c7fbc31f7..1f6ca0714 100644 --- a/.github/workflows/test-unit-vizro-ai.yml +++ b/.github/workflows/test-unit-vizro-ai.yml @@ -32,7 +32,7 @@ jobs: hatch-env: all.py3.11 - python-version: "3.12" hatch-env: all.py3.12 - - python-version: "3.12" + - python-version: "3.11" hatch-env: lower-bounds label: lower bounds diff --git a/.github/workflows/test-unit-vizro-core.yml b/.github/workflows/test-unit-vizro-core.yml index a10bb6060..6872efee2 100644 --- a/.github/workflows/test-unit-vizro-core.yml +++ b/.github/workflows/test-unit-vizro-core.yml @@ -34,7 +34,7 @@ jobs: hatch-env: all.py3.11 - python-version: "3.12" hatch-env: all.py3.12 - - python-version: "3.12" + - python-version: "3.11" hatch-env: lower-bounds label: lower bounds diff --git a/vizro-core/hatch.toml b/vizro-core/hatch.toml index 90e30a178..116349660 100644 --- a/vizro-core/hatch.toml +++ b/vizro-core/hatch.toml @@ -9,7 +9,7 @@ python = ["3.8", "3.9", "3.10", "3.11", "3.12"] # exception, so it can't be filtered out by pytest's filterwarnings. Instead we need # to modify sys.warnoptions upfront so that Kedro does not convert the warning to an # exception. -PYTHONWARNINGS = "ignore:Kedro is not yet fully compatible" +PYTHONWARNINGS = 'ignore:Kedro is not yet fully compatible with this Python version' [envs.changelog] dependencies = ["scriv"] diff --git a/vizro-core/pyproject.toml b/vizro-core/pyproject.toml index 4220d27b0..a94a9d003 100644 --- a/vizro-core/pyproject.toml +++ b/vizro-core/pyproject.toml @@ -75,7 +75,8 @@ addopts = [ filterwarnings = [ "error", # Ignore this warning here as it comes from pandas until pandas is made compatible with Python 3.12 - "ignore:.*utcfromtimestamp:DeprecationWarning" + "ignore:.*utcfromtimestamp:DeprecationWarning", + "ignore:Kedro is not yet fully compatible with this Python version" ] norecursedirs = ["tests/tests_utils", "tests/js"] pythonpath = ["tests/tests_utils"]