From 98d594854c970e2d0de0a317c52d8a22675134b4 Mon Sep 17 00:00:00 2001
From: Antony Milne <antony.milne@quantumblack.com>
Date: Tue, 5 Dec 2023 17:12:20 +0000
Subject: [PATCH] Correct env variable syntax

---
 .github/workflows/check-release.yml     |  6 +++---
 .github/workflows/checks-vizro-ai.yml   |  8 ++++----
 .github/workflows/checks-vizro-core.yml | 10 +++++-----
 .github/workflows/lint-vizro-all.yml    |  6 +++---
 .github/workflows/secret-scan.yml       |  4 ++--
 5 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/.github/workflows/check-release.yml b/.github/workflows/check-release.yml
index 069d30fda..bd7b31f2e 100644
--- a/.github/workflows/check-release.yml
+++ b/.github/workflows/check-release.yml
@@ -16,7 +16,7 @@ jobs:
       - name: Set up Python
         uses: actions/setup-python@v4
         with:
-          python-version: $PYTHON_VERSION
+          python-version: ${{ env.PYTHON_VERSION }}
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
@@ -53,7 +53,7 @@ jobs:
       - name: Set up Python
         uses: actions/setup-python@v4
         with:
-          python-version: $PYTHON_VERSION
+          python-version: ${{ env.PYTHON_VERSION }}
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
@@ -106,7 +106,7 @@ jobs:
       - name: Set up Python
         uses: actions/setup-python@v4
         with:
-          python-version: $PYTHON_VERSION
+          python-version: ${{ env.PYTHON_VERSION }}
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
diff --git a/.github/workflows/checks-vizro-ai.yml b/.github/workflows/checks-vizro-ai.yml
index 72296fe7a..3775cdff2 100644
--- a/.github/workflows/checks-vizro-ai.yml
+++ b/.github/workflows/checks-vizro-ai.yml
@@ -30,19 +30,19 @@ jobs:
         with:
           fetch-depth: ${{ github.event_name == 'pull_request' && 2 || 0 }}
 
-      - name: Set up Python $PYTHON_VERSION
+      - name: Set up Python ${{ env.PYTHON_VERSION }}
         uses: actions/setup-python@v4
         with:
-          python-version: $PYTHON_VERSION
+          python-version: ${{ env.PYTHON_VERSION }}
 
       - name: Install Hatch
         run: pip install --upgrade hatch
 
       - name: List dependencies
-        run: hatch run all.py$PYTHON_VERSION:pip freeze
+        run: hatch run all.py${{ env.PYTHON_VERSION }}:pip freeze
 
       - name: Check requirements for Snyk are up to date
-        run: hatch run all.py$PYTHON_VERSION:update-snyk-requirements --check
+        run: hatch run all.py${{ env.PYTHON_VERSION }}:update-snyk-requirements --check
 
       - name: Find added changelog fragments
         id: added-files
diff --git a/.github/workflows/checks-vizro-core.yml b/.github/workflows/checks-vizro-core.yml
index bff0e9152..96ca874a7 100644
--- a/.github/workflows/checks-vizro-core.yml
+++ b/.github/workflows/checks-vizro-core.yml
@@ -31,22 +31,22 @@ jobs:
         with:
           fetch-depth: ${{ github.event_name == 'pull_request' && 2 || 0 }}
 
-      - name: Set up Python $PYTHON_VERSION
+      - name: Set up Python ${{ env.PYTHON_VERSION }}
         uses: actions/setup-python@v4
         with:
-          python-version: $PYTHON_VERSION
+          python-version: ${{ env.PYTHON_VERSION }}
 
       - name: Install Hatch
         run: pip install --upgrade hatch
 
       - name: List dependencies
-        run: hatch run all.py$PYTHON_VERSION:pip freeze
+        run: hatch run all.py${{ env.PYTHON_VERSION }}:pip freeze
 
       - name: Check schema is up to date
-        run: hatch run all.py$PYTHON_VERSION:schema --check
+        run: hatch run all.py${{ env.PYTHON_VERSION }}:schema --check
 
       - name: Check requirements for Snyk are up to date
-        run: hatch run all.py$PYTHON_VERSION:update-snyk-requirements --check
+        run: hatch run all.py${{ env.PYTHON_VERSION }}:update-snyk-requirements --check
 
       - name: Find added changelog fragments
         id: added-files
diff --git a/.github/workflows/lint-vizro-all.yml b/.github/workflows/lint-vizro-all.yml
index 81c2d0446..32911efca 100644
--- a/.github/workflows/lint-vizro-all.yml
+++ b/.github/workflows/lint-vizro-all.yml
@@ -28,13 +28,13 @@ jobs:
         with:
           fetch-depth: ${{ github.event_name == 'pull_request' && 2 || 0 }}
 
-      - name: Set up Python $PYTHON_VERSION
+      - name: Set up Python ${{ env.PYTHON_VERSION }}
         uses: actions/setup-python@v4
         with:
-          python-version: $PYTHON_VERSION
+          python-version: ${{ env.PYTHON_VERSION }}
 
       - name: Install Hatch
         run: pip install --upgrade hatch
 
       - name: Lint
-        run: hatch run lint:lint
+        run: hatch run lint
diff --git a/.github/workflows/secret-scan.yml b/.github/workflows/secret-scan.yml
index ac297ba53..c240c6d7e 100644
--- a/.github/workflows/secret-scan.yml
+++ b/.github/workflows/secret-scan.yml
@@ -18,10 +18,10 @@ jobs:
 
       - uses: actions/setup-go@v4
 
-      - name: Set up Python $PYTHON_VERSION
+      - name: Set up Python ${{ env.PYTHON_VERSION }}
         uses: actions/setup-python@v4
         with:
-          python-version: $PYTHON_VERSION
+          python-version: ${{ env.PYTHON_VERSION }}
 
       - name: Install pre-commit
         run: pip install pre-commit