From 0d298c715c86c8755a0827b3443127a4cd8e50aa Mon Sep 17 00:00:00 2001 From: Antony Milne <49395058+antonymilne@users.noreply.github.com> Date: Tue, 21 Jan 2025 07:08:38 +0000 Subject: [PATCH] [Tidy] Move prettierignore and stylelintignore to pre-commit config (#962) --- .devcontainer/devcontainer.json | 6 ++---- .pre-commit-config.yaml | 3 ++- .prettierignore | 4 ---- .stylelintignore | 3 --- 4 files changed, 4 insertions(+), 12 deletions(-) delete mode 100644 .prettierignore delete mode 100644 .stylelintignore diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 0a7d4e85a..b7f016c72 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -6,9 +6,7 @@ "postAttachCommand": "cd vizro-core && hr examples:example", "customizations": { "vscode": { - "extensions": [ - "ms-python.python" - ] + "extensions": ["ms-python.python"] } }, "build": { @@ -18,7 +16,7 @@ "8050": { "label": "scratch_dev example" } - }, + } // It would be nice if the Python interpreter were automatically set in codespaces. // In theory this should work automatically but it doesn't seem to - maybe an issue with codespaces? // https://code.visualstudio.com/updates/v1_88#_hatch-environment-discovery diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 1107ba26c..ee2edec72 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -36,7 +36,7 @@ repos: language: node types: [text] additional_dependencies: ["prettier@3.3.3"] - exclude_types: [markdown] + exclude_types: [markdown, css] - repo: https://github.com/macisamuele/language-formatters-pre-commit-hooks rev: v2.14.0 @@ -83,6 +83,7 @@ repos: - stylelint-config-standard@36.0.0 - stylelint-order@4.1.0 args: ["--fix"] + exclude: ^vizro-core/src/vizro/static/css/.+\.min.*|^vizro-core/src/vizro/static/css/mantine_dates.css - repo: https://github.com/executablebooks/mdformat rev: 0.7.21 diff --git a/.prettierignore b/.prettierignore deleted file mode 100644 index 8981e2e60..000000000 --- a/.prettierignore +++ /dev/null @@ -1,4 +0,0 @@ -**/docs/ -**/.devcontainer/devcontainer.json -**/static/css/vizro-bootstrap.min.css -**/static/css/vizro-bootstrap.min.css.map diff --git a/.stylelintignore b/.stylelintignore deleted file mode 100644 index dcd27d71d..000000000 --- a/.stylelintignore +++ /dev/null @@ -1,3 +0,0 @@ -**/static/css/vizro-bootstrap.min.css -**/static/css/vizro-bootstrap.min.css.map -**/static/css/mantine_dates.css