Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aparte velden voor Nederlandse adressen naast adresregel 1 t/m 3 voor buitenlandse adressen #309

Open
alextreme opened this issue Dec 20, 2024 · 6 comments · May be fixed by #329
Open

Aparte velden voor Nederlandse adressen naast adresregel 1 t/m 3 voor buitenlandse adressen #309

alextreme opened this issue Dec 20, 2024 · 6 comments · May be fixed by #329
Assignees
Labels

Comments

@alextreme
Copy link
Member

alextreme commented Dec 20, 2024

Thema / Theme

Klantinteracties API

Omschrijving / Description

Het is te makkelijk om te denken dat voor elk adres er een BAG-id beschikbaar is. Voorkeur heeft ook vanuit Den Haag om straatnaam, huisnummer, toevoeging, postcode en stad velden toe te voegen. Hier dient dan ook validatie op uit te voeren (bijvoorbeeld validatie op Nederlandse postcodes)

Adresregels 1 t/m 3 wel intact laten voor buitenlandse velden.

Toegevoegde waarde / Added value

Betere datavalidatie en werking van Open Klant zonder BAG-id

Aanvullende opmerkingen / Additional context

No response

@alextreme alextreme added enhancement New feature or request triage labels Dec 20, 2024
@alextreme alextreme changed the title Aparte velden voor adres ipv adresregel 1 t/m 3 Aparte velden voor Nederlandse adressen naast adresregel 1 t/m 3 voor buitenlandse adressen Dec 20, 2024
@alextreme
Copy link
Member Author

@VerbeekIT vult aan bij eventuele alternatieve voorstellen

@joeribekker
Copy link
Member

joeribekker commented Jan 6, 2025

@joeribekker needs to validate this with existing patterns in APIs before @danielmursa-dev can pick this up.

@joeribekker
Copy link
Member

Approved by Alex-proxy due to prio.

@alextreme alextreme moved this from Triage to Todo in Data en API fundament Jan 20, 2025
@danielmursa-dev danielmursa-dev moved this from Todo to In Progress in Data en API fundament Feb 4, 2025
@danielmursa-dev
Copy link
Contributor

@joeribekker

I checked the existing patterns and the new fields to be added with their validations are as follows:

straatnaam           -> string  -> [255]
huisnummer           -> int     -> [1, 99999]
huisnummertoevoeging -> string  -> [20]
postcode             -> string  -> '^[1-9]{1}[0-9]{3}[a-zA-Z]{2}$' -> example: '6922KZ'
stad                 -> string  -> [255]

In addition, there is also the huisletter field which could be added.

Before proceeding, I would like to confirm the new fields to be added

@alextreme
Copy link
Member Author

@danielmursa-dev you have permission to continue, @VerbeekIT or @joeribekker may have comments but the specified fields and validation are in line with my issue

@VerbeekIT
Copy link

VerbeekIT commented Feb 4, 2025 via email

danielmursa-dev added a commit that referenced this issue Feb 5, 2025
@danielmursa-dev danielmursa-dev linked a pull request Feb 5, 2025 that will close this issue
@danielmursa-dev danielmursa-dev moved this from In Progress to Implemented in Data en API fundament Feb 5, 2025
danielmursa-dev added a commit that referenced this issue Feb 5, 2025
danielmursa-dev added a commit that referenced this issue Feb 5, 2025
[#309] Create and fix tests

[#309] Fix admin and schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Implemented
Development

Successfully merging a pull request may close this issue.

4 participants