Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that chunked requests should not be used, or add nginx to Open Klant helm chart (and most likely Objects+ObjectTypes too) #299

Open
alextreme opened this issue Dec 5, 2024 · 0 comments · May be fixed by maykinmedia/charts#182
Assignees
Labels
bug Something isn't working enhancement New feature or request owner: utrecht

Comments

@alextreme
Copy link
Member

Thema / Theme

Klantinteracties API

Omschrijving / Description

Currently we use Open Klant with uwsgi-in-http-mode (as most components) however our helm charts are without nginx.

This works, but it does depend on the client not using HTTP 1 chunked requests (KISS did). If a client does then uwsgi will not process the body of the requests and Django doesn't see the contents. This was discovered by Utrecht by Marcel and Jordi, which also depends on which K8s ingress is used because if you communicate via an nginx-ingress or via an nginx pod then the problem doesn't occur (nginx supports chunked requests).

Lets either document this limitation of Open Klant, or (which I would prefer) is ensure that Open Klant and our other components always have nginx in front of them. Our SaaS-installs are set up this way, and we have nginx in our Open Zaak / Open Forms / Open Inwoner charts I'd want to avoid exposing uwsgi-specific restrictions if we can avoid this.

Further reading:

https://uwsgi-docs.readthedocs.io/en/latest/HTTP.html#can-i-use-uwsgi-s-http-capabilities-in-production

Toegevoegde waarde / Added value

No response

Aanvullende opmerkingen / Additional context

No response

@alextreme alextreme added bug Something isn't working enhancement New feature or request triage labels Dec 5, 2024
@alextreme alextreme moved this from Triage to Todo in Data en API fundament Jan 20, 2025
@danielmursa-dev danielmursa-dev moved this from Todo to In Progress in Data en API fundament Feb 6, 2025
danielmursa-dev added a commit to maykinmedia/charts that referenced this issue Feb 6, 2025
@danielmursa-dev danielmursa-dev moved this from In Progress to Implemented in Data en API fundament Feb 6, 2025
@stevenbal stevenbal removed the triage label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request owner: utrecht
Projects
Status: Implemented
Development

Successfully merging a pull request may close this issue.

4 participants