Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CI pipelines the same across projects #13

Closed
2 tasks
stevenbal opened this issue Apr 12, 2024 · 4 comments · Fixed by open-zaak/open-zaak#1730, maykinmedia/open-klant#238, maykinmedia/objecttypes-api#129, open-zaak/open-notificaties#189 or maykinmedia/objects-api#447
Closed
2 tasks

Make CI pipelines the same across projects #13

stevenbal opened this issue Apr 12, 2024 · 4 comments · Fixed by open-zaak/open-zaak#1730, maykinmedia/open-klant#238, maykinmedia/objecttypes-api#129, open-zaak/open-notificaties#189 or maykinmedia/objects-api#447
Assignees
@stevenbal
Labels
enhancement New feature or request owner: maykin

Comments

@stevenbal
Copy link
Collaborator

stevenbal commented Apr 12, 2024 •
edited by joeribekker
Loading

Not sure if this repo is the right place for this issue, but I noticed that Open Zaak has an image_scan job in the CI pipeline: https://github.com/open-zaak/open-zaak/blob/main/.github/workflows/ci.yml#L268. Is this something we want in the other projects as well?

In general, I think it is a good idea to check if the pipelines are the same (or at least as close as possible) and up to date when it comes to versions for actions

  • Add the best things to the default project - api folder.
  • Make sure all the API projects have similar CI pipelines
@stevenbal stevenbal added the triage Triage means the team has not yet refined this issue. label Apr 12, 2024
@stevenbal
Copy link
Collaborator Author

Maybe we could make use of https://github.com/maykinmedia/setup-django-backend/tree/v1.3

@joeribekker joeribekker added enhancement New feature or request and removed triage Triage means the team has not yet refined this issue. labels Jun 18, 2024
@joeribekker joeribekker moved this from Triage to Todo in Data en API fundament Jun 18, 2024
@SonnyBA SonnyBA moved this from Todo to In Progress in Data en API fundament Jul 23, 2024
@SonnyBA SonnyBA added the triage Triage means the team has not yet refined this issue. label Jul 30, 2024
@joeribekker joeribekker removed the triage Triage means the team has not yet refined this issue. label Jul 30, 2024
@SonnyBA SonnyBA mentioned this issue Jul 31, 2024
Merged
@SonnyBA
Copy link
Contributor

SonnyBA commented Aug 6, 2024

A first effort to make the CI pipelines more consistent was made through open-zaak/#1730. The code quality workflow was used for this and now reuses the code quality workflow from the open-api-workflows repository.

@SonnyBA SonnyBA added the triage Triage means the team has not yet refined this issue. label Aug 6, 2024
@SonnyBA
Copy link
Contributor

SonnyBA commented Aug 6, 2024

Moving the workflow files to the root repository does not seem possible (screenshot taken from an open-zaak run):

Image

@SonnyBA SonnyBA removed the triage Triage means the team has not yet refined this issue. label Aug 6, 2024
@alextreme alextreme moved this from In Progress to Todo in Data en API fundament Aug 13, 2024
@stevenbal stevenbal mentioned this issue Aug 15, 2024
Merged
@SonnyBA SonnyBA moved this from Todo to In Progress in Data en API fundament Sep 6, 2024
@SonnyBA
Copy link
Contributor

SonnyBA commented Sep 6, 2024 •
edited
Loading

@SonnyBA SonnyBA mentioned this issue Sep 6, 2024
Merged
This was referenced Sep 17, 2024
Merged
Merged
Merged
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Data en API fundament Oct 4, 2024
@stevenbal stevenbal reopened this Oct 25, 2024
@github-project-automation github-project-automation bot moved this from Implemented to In Progress in Data en API fundament Oct 25, 2024
@stevenbal stevenbal assigned stevenbal and unassigned SonnyBA Oct 25, 2024
@github-project-automation github-project-automation bot moved this from Implemented to Done in Data en API fundament Oct 31, 2024
github-merge-queue bot pushed a commit to infonl/dimpact-zaakafhandelcomponent that referenced this issue Feb 19, 2025
@renovate
chore(deps): update docker.io/openzaak/open-notificaties docker tag t…
c588f4c 
…o v1.8.0 (#2737)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[docker.io/openzaak/open-notificaties](https://redirect.github.com/open-zaak/open-notificaties)
| minor | `1.7.1` -> `1.8.0` |

---

### Release Notes

<details>
<summary>open-zaak/open-notificaties
(docker.io/openzaak/open-notificaties)</summary>

###
[`v1.8.0`](https://redirect.github.com/open-zaak/open-notificaties/blob/HEAD/CHANGELOG.rst#180-2025-01-13)

[Compare
Source](https://redirect.github.com/open-zaak/open-notificaties/compare/1.7.1...1.8.0)

**New features**

-
\[[#&#8203;108](https://redirect.github.com/open-zaak/open-notificaties/issues/108)]
Admin action to check Abonnement callback status
-
\[[#&#8203;180](https://redirect.github.com/open-zaak/open-notificaties/issues/180)]
Provide an admin overview for notificatie responses
-
\[[#&#8203;207](https://redirect.github.com/open-zaak/open-notificaties/issues/207)]
Add experimental PUT and PATCH for Kanaal
-
\[[#&#8203;199](https://redirect.github.com/open-zaak/open-notificaties/issues/199)]
Add Admin OIDC Configuration step from django-setup-configuration
-
\[[#&#8203;204](https://redirect.github.com/open-zaak/open-notificaties/issues/204)]
Add SitesConfiguration step from django-setup-configuration
-
\[[#&#8203;200](https://redirect.github.com/open-zaak/open-notificaties/issues/200)]
Autorisaties-API configuration via django-setup-configuration
-
\[[#&#8203;202](https://redirect.github.com/open-zaak/open-notificaties/issues/202)]
Configuration Kanalen via django-setup-configuration
-
\[[#&#8203;202](https://redirect.github.com/open-zaak/open-notificaties/issues/202)]
Configuration Abonnementen via django-setup-configuration
-
\[[#&#8203;203](https://redirect.github.com/open-zaak/open-notificaties/issues/203)]
Configuration Notification settings via django-setup-configuration
-
\[[maykinmedia/open-api-framework#46](https://redirect.github.com/maykinmedia/open-api-framework/issues/46)]
Upgrade open-api-framework to 0.9.1

**Bugfixes and QOL**

-
\[[maykinmedia/open-api-framework#66](https://redirect.github.com/maykinmedia/open-api-framework/issues/66)]
Update zgw consumers to 0.36.0
-
\[[#&#8203;199](https://redirect.github.com/open-zaak/open-notificaties/issues/199)]
Upgrade mozilla-django-oidc-db to 0.21.1
-
\[[#&#8203;203](https://redirect.github.com/open-zaak/open-notificaties/issues/203)]
Upgrade notifications-api-common to 0.4.0
-
\[[#&#8203;204](https://redirect.github.com/open-zaak/open-notificaties/issues/204)]
Upgrade django-setup-configuration to 0.5.0
-
\[[#&#8203;200](https://redirect.github.com/open-zaak/open-notificaties/issues/200)]
Fix `CELERY_LOGLEVEL` not working
-
\[[#&#8203;200](https://redirect.github.com/open-zaak/open-notificaties/issues/200)]
Upgrade commonground-api-common to 2.2.0

.. warning::

Configuring external services is now done through the `Service` model.
This
replaces the `APICredential` model in the admin interface. A data
migration
was added to move to the `Service` model. It is advised to verify the
`Service`
instances in the admin to check that the data migration was ran as
expected.

.. warning::

``LOG_STDOUT`` configuration variable now defaults to ``True`` instead
of ``False``

.. warning::

    The previous setup configurations are no longer supported.
    Make sure to replace the old configurations with the new ones.

**Project maintenance**

-
\[[maykinmedia/objects-api#463](https://redirect.github.com/maykinmedia/objects-api/issues/463)]
Add trivy image scan
-
\[[maykinmedia/open-api-framework#92](https://redirect.github.com/maykinmedia/open-api-framework/issues/92)]
Fix docker latest tag publish
-
\[[maykinmedia/open-api-framework#13](https://redirect.github.com/maykinmedia/open-api-framework/issues/13)]
Consistent CI configuration across the different projects.

**Documentation**

-
\[[#&#8203;200](https://redirect.github.com/open-zaak/open-notificaties/issues/200)]
Update docs for setup configuration changes
-
\[[maykinmedia/objects-api#403](https://redirect.github.com/maykinmedia/objects-api/issues/403)]
Update delivery guarantee documentation

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/infonl/dimpact-zaakafhandelcomponent).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNzMuMSIsInVwZGF0ZWRJblZlciI6IjM5LjE3My4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenbal stevenbal

Labels
enhancement New feature or request owner: maykin
Projects
Data en API fundament
Archived in project
Milestone
No milestone
3 participants
@joeribekker @SonnyBA @stevenbal