Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotes deleted when empty #17

Open
haleighkay opened this issue Mar 17, 2017 · 2 comments
Open

Quotes deleted when empty #17

haleighkay opened this issue Mar 17, 2017 · 2 comments
Labels

Comments

@haleighkay
Copy link

There are cases where you might want an empty alt tag on an image, like for a spacer image. It’s best practice to have the alt attribute on all images, even if it’s empty, it’s better than none at all. And since it is blank, it's less annoying for screen readers to have nothing there than to say something like "blank spacer image" and less abrasive if the image doesn't load to not have actual alt text show up and thereby keep it as small as possible.
The compiler is currently deleting said empty quotes, as seen below:

2836650129-screen shot 2017-03-14 at 11 22 01 am
2457946575-screen shot 2017-03-14 at 11 21 47 am

@maxlapides maxlapides added the bug label Mar 17, 2017
@revelt
Copy link

revelt commented Apr 5, 2017

I did some investigation, it's not coming from email-remove-unused-css dependency (just tested on v1.16.0), you can check it yourself on emailcomb.com with live code. It's some other dependency library causing this.

Can you guys confirm this bug is still happening? I don't want to assemble a dummy dovetailer project just to check. Cheers.

@maxlapides
Copy link
Owner

@revelt sorry, i do think this is still an issue. i've been very busy the past few weeks, but i should be able to address this soon! and PRs are always welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants