Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in transaction does not raise any error #174

Open
jgoyon opened this issue May 23, 2014 · 0 comments
Open

Error in transaction does not raise any error #174

jgoyon opened this issue May 23, 2014 · 0 comments

Comments

@jgoyon
Copy link

jgoyon commented May 23, 2014

Sending a invalid statements to the REST transaction endpoint does not raise errors.

According to Neo4j docs

All requests against the transactional endpoint will return 200 or 201 status code, regardless of whether statements were successfully executed.

Neography not raising any errors make sense, as there is no error during the request. Nevertheless, letting a request silently fail does not seems a desired behaviour.

Currently, the solution is to read the errors array in the response returned when sending POST request to the transaction endpoint. Why not systematically raise an error when this array is not empty here ? It would be easy to catch (and silent if we don't care) but make it easier to spot bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant