Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Websocket disconnect gracefully #65

Open
mattsse opened this issue Oct 7, 2021 · 1 comment
Open

Handle Websocket disconnect gracefully #65

mattsse opened this issue Oct 7, 2021 · 1 comment

Comments

@mattsse
Copy link
Owner

mattsse commented Oct 7, 2021

In the event the websocket crashes no more commands can be send or received so in that we case we should

  • drop the Handler entirely short term
  • add the option to try a reconnect, number of retries should be configureable.
@Sytten
Copy link
Contributor

Sytten commented Jan 12, 2023

For some reason I am seeing websocket crashes in my Github CI, with the log Error: chromiumoxide::handler: WS Connection error: Ws(Protocol(ResetWithoutClosingHandshake)). So it might help to get a reconnect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants