From 6dfac53daf103c7431a10fcac4a58850f1809051 Mon Sep 17 00:00:00 2001 From: Acelya Date: Tue, 26 Mar 2024 15:18:20 +0000 Subject: [PATCH] fix: remove --disable-extensions when --load-extension is used --- src/browser.rs | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/browser.rs b/src/browser.rs index 17dac756..d939e9f7 100644 --- a/src/browser.rs +++ b/src/browser.rs @@ -863,11 +863,15 @@ impl BrowserConfig { cmd.arg(format!("--remote-debugging-port={}", self.port)); } - cmd.args( - self.extensions - .iter() - .map(|e| format!("--load-extension={e}")), - ); + if self.extensions.is_empty() { + cmd.arg("--disable-extensions"); + } else { + cmd.args( + self.extensions + .iter() + .map(|e| format!("--load-extension={e}")), + ); + } if let Some(ref user_data) = self.user_data_dir { cmd.arg(format!("--user-data-dir={}", user_data.display())); @@ -923,7 +927,7 @@ pub fn default_executable() -> Result { /// These are passed to the Chrome binary by default. /// Via https://github.com/puppeteer/puppeteer/blob/4846b8723cf20d3551c0d755df394cc5e0c82a94/src/node/Launcher.ts#L157 -static DEFAULT_ARGS: [&str; 25] = [ +static DEFAULT_ARGS: [&str; 24] = [ "--disable-background-networking", "--enable-features=NetworkService,NetworkServiceInProcess", "--disable-background-timer-throttling", @@ -933,7 +937,6 @@ static DEFAULT_ARGS: [&str; 25] = [ "--disable-component-extensions-with-background-pages", "--disable-default-apps", "--disable-dev-shm-usage", - "--disable-extensions", "--disable-features=TranslateUI", "--disable-hang-monitor", "--disable-ipc-flooding-protection",