Confusion re deliveryTime for CollectionCarrier.

[kt86]

From @JWJoubert:
We found it a bit counter-intuitive (it took us some time to pinpoint the discrepancy) that for the LspShipment, the “collection” or pick-up time, the code uses the “delivery time”, even though the LspShipment does have a “pickupServiceTime” option.

From my first view on it, this seems to be wrong in the code, so that in

logistics/src/main/java/org/matsim/freight/logistics/resourceImplementations/CollectionCarrierScheduler.java

Line 89 in c931692

.setServiceDuration(lspShipment.getDeliveryServiceTime())

and

logistics/src/main/java/org/matsim/freight/logistics/resourceImplementations/CollectionCarrierScheduler.java

Line 137 in c931692

builder.setEndTime(startTimeOfLoading + lspShipment.getDeliveryServiceTime());

(?) it should use get**Pickup**...

Just changing the code will cause a lot of test failures (which is somehow, good, showing, that this is tested)

[JWJoubert]

Just changing the code will cause a lot of test failures (which is somehow, good, showing, that this is tested)

Well done for many tests!

Just changing the code...

Do you mean changing it in this one particular place only? What will be needed? A more thorough walk through the code and tracing its implications? What would your first prize be?

[JWJoubert]

@kt86, can you please add XanderPENG (GitHub username) to this project? It would be good if he gets up to speed of the developments.

[kt86]

Dear @JWJoubert , I invited him with write permissions.

[kt86]

Do you mean changing it in this one particular place only? What will be needed? A more thorough walk through the code and tracing its implications? What would your first prize be?

I assume, that is the main point, where the transformation from the LspShipment to all the internal logic is done. But of course, it would be a very good idea, to walk a bit more along the code and see, if this assumption is correct.
I also assume, that one sees a lot, when walking through the simple tests - starting with tests consisting only of the CollectionCarrierRessource - and analyze, whether the "new" solution now is the correct one.

((My note was a more quick note for myself and therefore a bit casual/offhand. Sorry for that. I will try to start again getting things formulated a bit better and also add (temporal) comments again in English ))

[kt86]

Moved issue to matsim-org/matsim-libs#3604