Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate signals reader into osm reader #850

Open
5 of 7 tasks
kainagel opened this issue Feb 25, 2020 · 2 comments
Open
5 of 7 tasks

integrate signals reader into osm reader #850

kainagel opened this issue Feb 25, 2020 · 2 comments
Assignees

Comments

@kainagel
Copy link
Member

kainagel commented Feb 25, 2020

The osm-network reader which respects signals is the last network reader which depends on the old xml-reader. Changing it to the pbf version would complete the osm-contrib for now.

  • It seems like the singal stuff needs the osm-reader to be inheritable (non final) (janek)
  • Pass Osm-Parser to Osm-Reader from Builder (janek)
  • Make Builder inheritable (janek)
  • create skeleton implementation of signals reader (janek)
  • create unit tests as spec (söhnke)
  • finalize implementation (söhnke)
  • add integration test (söhnke)
@Janekdererste
Copy link
Member

@tthunig is this still in progress?

@tthunig
Copy link
Contributor

tthunig commented Dec 16, 2020

Yes, it is. The implementation is done. Söhnke is working on the tests. Then we need to pull in the master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants