Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move getVehiclesSource() from QsimConfigGroup somewhere else #1084

Open
jfbischoff opened this issue Jul 23, 2020 · 3 comments
Open

Move getVehiclesSource() from QsimConfigGroup somewhere else #1084

jfbischoff opened this issue Jul 23, 2020 · 3 comments
Labels
maintenance things that should be done to improve code and UI

Comments

@jfbischoff
Copy link
Collaborator

The vehicle Source is currently determined by in a config Switch in QSim Config Group.
That said, it is mostly used in PersonPrepareForSimImpl, which is independent of the Mobsim one is using. Qsim uses it additionally in PopulationAgentSource (which is probably the reason why the switch ended up there in the first place).
That leads to the somewhat unintuitive behavior that one has to set a switch in Qsim Config Group, indepent of the Mobsim used. Certainly not a drama, but odd nonetheless.

I would propose moving this Config Setting somewhere else in mid-term. Any ideas what would be a better place? VehiclesConfigGroup perhaps?
@mrieser @Janekdererste @kainagel Feel free to discuss :-)

@jfbischoff jfbischoff added the maintenance things that should be done to improve code and UI label Jul 23, 2020
@mrieser
Copy link
Contributor

mrieser commented Jul 23, 2020

PersonPrepareForSim seems to be used by PrepareForMobsimImpl, which is used by (New)Controler.
--> ControlerConfigGroup?

@Janekdererste
Copy link
Member

Since it is related to vehicles, why not move it into the vehicle section?

@jfbischoff jfbischoff changed the title Move getVehiclesSource() to from QsimConfigGroup somewhere else Move getVehiclesSource() from QsimConfigGroup somewhere else Jul 23, 2020
@kainagel
Copy link
Member

kainagel commented Jul 23, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance things that should be done to improve code and UI
Projects
None yet
Development

No branches or pull requests

4 participants