Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Add support for composer icon #203

Closed
azdanov opened this issue Feb 18, 2018 · 8 comments · May be fixed by #1140
Closed

[REQUEST] Add support for composer icon #203

azdanov opened this issue Feb 18, 2018 · 8 comments · May be fixed by #1140

Comments

@azdanov
Copy link

azdanov commented Feb 18, 2018

Support for composer.json would be really nice. It's a PHP package manager.

There is a font available here technology-icons containing composer glyph. And a few png on official repo.

@PKief
Copy link
Member

PKief commented Feb 24, 2018

I tried to use the composer icon but it does hardly fit into the icon theme. It's difficult to use such an icon with so many details. That's because the icons have a very small size in the explorer of VS Code. So it is always better to have simple and clean icons.

Let's see, maybe I'll find a possible solution for this icon but I'm currently not sure about it.

@azdanov
Copy link
Author

azdanov commented Feb 24, 2018

What about this svg image from file-icons?
There's only a silhouette there, without any details.

So using that icon with a color like #f28d1a* could work?

* This color is used on official composer repository packagist.com

@PKief
Copy link
Member

PKief commented Feb 25, 2018

@azdanov No, I don't like the image from file-icons. It's clean and simple, but not very nice. Then I'd rather use the original composer icon. But let's see 😃

@PKief
Copy link
Member

PKief commented Mar 7, 2018

I tried again to insert the icon into the theme. Unfortunately I don't like it at all, so there will be no icon for composer at the moment. It just doesn't fit to the other icons. I'm sorry about that.

@PKief PKief closed this as completed Mar 7, 2018
@rbalet
Copy link
Contributor

rbalet commented Mar 28, 2019

I tried to find a way to have a composer icon.
(It isn't finish yet, but I wanted to know if you may find it a good Idea or if you are definitively not gonna have any composer icon)
Asset 4

@PKief
Copy link
Member

PKief commented Mar 28, 2019

The problem is that the Composer icon has very detailed small outlines which are difficult to recognize as an icon in the file explorer. I also think that the file composer.json already has a good icon with the JSON icon and that there is not much need for an own icon. Of course I know that the recognition for Composer with its own icon would be better, but we still have to find a suitable icon. I'll open the issue again to keep track of it 😉

@PKief PKief reopened this Mar 28, 2019
@Atn-D
Copy link

Atn-D commented Feb 3, 2020

I tried a better vectorization of it.
It's true that it's not very recognizable in small size.

Screenshot 2020-02-03 at 15 40 23

Maybe it's with a detached element?

Screenshot 2020-02-03 at 15 41 01

Screenshot 2020-02-03 at 15 41 08

Screenshot 2020-02-03 at 15 41 13

@codewithleader
Copy link

The problem is that the Composer icon has very detailed small outlines which are difficult to recognize as an icon in the file explorer. I also think that the file composer.json already has a good icon with the JSON icon and that there is not much need for an own icon. Of course I know that the recognition for Composer with its own icon would be better, but we still have to find a suitable icon. I'll open the issue again to keep track of it 😉

Here I come to encourage you so that you do not give up on adding the Composer icon. I tried switching to VSCode Icons, which does have it, but the Material Icons set is truly unbeatable. Please consider adding the Composer icon so that our happiness can be complete. When I see that .json icon, it makes Composer files look like just another .json file! I believe that without that icon, our experience cannot be fully enriched. But what a joy it would be if you manage to add it! 😆 Plllllsssss

@azdanov azdanov closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants